-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TGUI]Dropdown upgrade #26987
[TGUI]Dropdown upgrade #26987
Conversation
Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com> Signed-off-by: ROdenFL <ROdenFL@yandex.ru>
This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord. |
Stop it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Please rebuild bundles when able.
not ur PR that causes it but noticed that the brigtimer doesn't sanitize the name inputted in it. No href fuckery even needed, it just disabled encoding. |
What Does This PR Do
Port /tg/ pre-react dropdown and modificate it to better look.
port: move dropdown into Stack and buttons option
modification: smaller buttons size, inline stack
Why It's Good For The Game
It is easier to make new dropdowns, dropdowns better suit in containers they are situated
Images of changes
example of buttons, which are not used anywhere
![image](https://private-user-images.githubusercontent.com/144662735/373799459-b9ab3ff2-b5d9-4460-b5fd-29610587185c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MDM3NjQsIm5iZiI6MTczOTYwMzQ2NCwicGF0aCI6Ii8xNDQ2NjI3MzUvMzczNzk5NDU5LWI5YWIzZmYyLWI1ZDktNDQ2MC1iNWZkLTI5NjEwNTg3MTg1Yy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNzExMDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hYTZmZmE3NjNhMzlhNDE2MTNmODIzZWYyNTZjMzNmODVlMDg3NGQ1OTdmMWJjMGZhY2EzNzBjYTgwM2U3YzMwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.oZ9HNGAP6OTiUEhpqI3atRb6kOrS3Hx0Ghsru3qZGRk)
Testing
checked all other dropdowns, to make sure they're not changed
Declaration