Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TGUI]Dropdown upgrade #26987

Merged
merged 3 commits into from
Nov 9, 2024
Merged

[TGUI]Dropdown upgrade #26987

merged 3 commits into from
Nov 9, 2024

Conversation

ROdenFL
Copy link
Contributor

@ROdenFL ROdenFL commented Oct 4, 2024

What Does This PR Do

Port /tg/ pre-react dropdown and modificate it to better look.

port: move dropdown into Stack and buttons option
modification: smaller buttons size, inline stack

Why It's Good For The Game

It is easier to make new dropdowns, dropdowns better suit in containers they are situated

Images of changes

example of buttons, which are not used anywhere
image

Testing

checked all other dropdowns, to make sure they're not changed


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

@ROdenFL ROdenFL closed this Oct 4, 2024
@ROdenFL ROdenFL reopened this Oct 4, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Oct 4, 2024
Co-authored-by: Aylong <69762909+AyIong@users.noreply.github.com>
Signed-off-by: ROdenFL <ROdenFL@yandex.ru>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Oct 5, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Oct 10, 2024
Copy link
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Oct 25, 2024
@AyIong
Copy link
Contributor

AyIong commented Oct 25, 2024

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

Stop it

@github-actions github-actions bot removed the Stale This PR has been left inactive and requires an update. label Oct 26, 2024
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Please rebuild bundles when able.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 8, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 9, 2024
@Burzah Burzah added this pull request to the merge queue Nov 9, 2024
Merged via the queue into ParadiseSS13:master with commit 0b79bc2 Nov 9, 2024
12 checks passed
@DrPepperIsSpicy
Copy link

not ur PR that causes it but noticed that the brigtimer doesn't sanitize the name inputted in it. No href fuckery even needed, it just disabled encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants