Byondstorage tweaks #26423
Merged
Byondstorage tweaks #26423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am sufficiently confident that this fixed the issue |
Burzah
approved these changes
Aug 8, 2024
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Aug 11, 2024
jlsnow301
pushed a commit
to tgstation/tgstation
that referenced
this pull request
Dec 31, 2024
## About The Pull Request This implements a byondstorage backend for TGUI, via porting the relevant portion of these PRs from Paradise: - ParadiseSS13/Paradise#25363 - ParadiseSS13/Paradise#26423 - ParadiseSS13/Paradise#26617 Also rewrote `storage.js` to TypeScript ## Proof that it works <details> <summary>Screenshots</summary>   </details> ## Why It's Good For The Game saving chat settings is good ## Changelog :cl: Absolucy, S34NW fix: Chat settings properly save on BYOND 516 now. Settings still won't carry over from 515 tho, 515 and 516 settings will be separate. /:cl:
github-merge-queue bot
pushed a commit
to cmss13-devs/cmss13
that referenced
this pull request
Jan 1, 2025
this is a combination of. ParadiseSS13/Paradise#25105 ParadiseSS13/Paradise#25205 ParadiseSS13/Paradise#25363 ParadiseSS13/Paradise#26423 ParadiseSS13/Paradise#26433 VOREStation/VOREStation#16734 ~~still requires storage testing + 515 testing + skin changes testing~~ it's fine :cl: server: the server can now support 516 clients - be aware that the current version (516.1648) has some crashing issues, and you may not want to update yet. the server can also be hosted on 516 versions, but this will force all clients to use 516 /:cl: --------- Co-authored-by: forest2001 <forest2001@cm-ss13.com>
FlufflesTheDog
pushed a commit
to NovaSector/NovaSector
that referenced
this pull request
Jan 9, 2025
## About The Pull Request This implements a byondstorage backend for TGUI, via porting the relevant portion of these PRs from Paradise: - ParadiseSS13/Paradise#25363 - ParadiseSS13/Paradise#26423 - ParadiseSS13/Paradise#26617 Also rewrote `storage.js` to TypeScript ## Proof that it works <details> <summary>Screenshots</summary>   </details> ## Why It's Good For The Game saving chat settings is good ## Changelog :cl: Absolucy, S34NW fix: Chat settings properly save on BYOND 516 now. Settings still won't carry over from 515 tho, 515 and 516 settings will be separate. /:cl:
Iajret
pushed a commit
to Fluffy-Frontier/FluffySTG
that referenced
this pull request
Jan 15, 2025
## About The Pull Request This implements a byondstorage backend for TGUI, via porting the relevant portion of these PRs from Paradise: - ParadiseSS13/Paradise#25363 - ParadiseSS13/Paradise#26423 - ParadiseSS13/Paradise#26617 Also rewrote `storage.js` to TypeScript ## Proof that it works <details> <summary>Screenshots</summary>   </details> ## Why It's Good For The Game saving chat settings is good ## Changelog :cl: Absolucy, S34NW fix: Chat settings properly save on BYOND 516 now. Settings still won't carry over from 515 tho, 515 and 516 settings will be separate. /:cl:
itsmeow
pushed a commit
to itsmeowForks/BeeStation-Hornet
that referenced
this pull request
Feb 2, 2025
This implements a byondstorage backend for TGUI, via porting the relevant portion of these PRs from Paradise: - ParadiseSS13/Paradise#25363 - ParadiseSS13/Paradise#26423 - ParadiseSS13/Paradise#26617 Also rewrote `storage.js` to TypeScript <details> <summary>Screenshots</summary>   </details> saving chat settings is good :cl: Absolucy, S34NW fix: Chat settings properly save on BYOND 516 now. Settings still won't carry over from 515 tho, 515 and 516 settings will be separate. /:cl:
nevimer
pushed a commit
to Bubberstation/Bubberstation
that referenced
this pull request
Feb 2, 2025
## About The Pull Request This implements a byondstorage backend for TGUI, via porting the relevant portion of these PRs from Paradise: - ParadiseSS13/Paradise#25363 - ParadiseSS13/Paradise#26423 - ParadiseSS13/Paradise#26617 Also rewrote `storage.js` to TypeScript ## Proof that it works <details> <summary>Screenshots</summary>   </details> ## Why It's Good For The Game saving chat settings is good ## Changelog :cl: Absolucy, S34NW fix: Chat settings properly save on BYOND 516 now. Settings still won't carry over from 515 tho, 515 and 516 settings will be separate. /:cl:
itsmeow
pushed a commit
to itsmeowForks/BeeStation-Hornet
that referenced
this pull request
Feb 7, 2025
This implements a byondstorage backend for TGUI, via porting the relevant portion of these PRs from Paradise: - ParadiseSS13/Paradise#25363 - ParadiseSS13/Paradise#26423 - ParadiseSS13/Paradise#26617 Also rewrote `storage.js` to TypeScript <details> <summary>Screenshots</summary>   </details> saving chat settings is good :cl: Absolucy, S34NW fix: Chat settings properly save on BYOND 516 now. Settings still won't carry over from 515 tho, 515 and 516 settings will be separate. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Refactors some TGUI storage code to hopefully avoid unrecoverable crashes. Will need extended TM to ensure this works.
Fixes #26181
Why It's Good For The Game
Chat shouldn't randomly BSOD for people. Why was I allowed to write code like this?
Testing
Loaded up the game in 516 and 515, chat worked.