-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds names and descriptions to most bullets and ammo boxes #24363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fordoxia
reviewed
Feb 29, 2024
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Fordoxia
reviewed
Feb 29, 2024
Fordoxia
reviewed
Feb 29, 2024
Fordoxia
reviewed
Feb 29, 2024
Fordoxia
reviewed
Feb 29, 2024
Fordoxia
reviewed
Feb 29, 2024
Fordoxia
reviewed
Feb 29, 2024
Fordoxia
reviewed
Feb 29, 2024
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Henri215
reviewed
Feb 29, 2024
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Henri215
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lewcs Good to Me
S34NW
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting merge
This PR is ready for merge
Grammar and Formatting
This PR fixes grammar issues or bad formatting
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
See title.
Why It's Good For The Game
Currently, every single bullet in the game has the exact same name and near-identical descriptions, which doesn't make much sense.
Secondly, I am aware many of our players and staff do not come from the Land of the Free, and thus may need help identifying what a bullet does, and to what gun it goes.
This should hopefully rectify both issues.
Testing
Changelog
🆑
tweak: Added names and descriptions to many bullets and ammo boxes
/:cl: