Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds names and descriptions to most bullets and ammo boxes #24363

Merged
merged 7 commits into from
Mar 1, 2024

Conversation

PopeDaveThe3th
Copy link
Contributor

What Does This PR Do

See title.

Why It's Good For The Game

Currently, every single bullet in the game has the exact same name and near-identical descriptions, which doesn't make much sense.

Secondly, I am aware many of our players and staff do not come from the Land of the Free, and thus may need help identifying what a bullet does, and to what gun it goes.

This should hopefully rectify both issues.

Testing

  • Loaded in
  • Spawned many bullets and ammo boxes
  • Names and descriptions have changed

Changelog

🆑
tweak: Added names and descriptions to many bullets and ammo boxes
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Feb 29, 2024
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 29, 2024
@Henri215 Henri215 added the Grammar and Formatting This PR fixes grammar issues or bad formatting label Feb 29, 2024
PopeDaveThe3th and others added 3 commits February 29, 2024 10:26
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Feb 29, 2024
PopeDaveThe3th and others added 2 commits March 1, 2024 06:11
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Copy link
Contributor

@Henri215 Henri215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lewcs Good to Me

@Henri215 Henri215 requested a review from Fordoxia March 1, 2024 12:04
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Mar 1, 2024
@S34NW S34NW merged commit 7c0ce05 into ParadiseSS13:master Mar 1, 2024
11 checks passed
@PopeDaveThe3th PopeDaveThe3th deleted the guns-&-ammo-desc branch March 1, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Grammar and Formatting This PR fixes grammar issues or bad formatting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants