Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welding tools can be used to light other people's cigarettes #23987

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

Fordoxia
Copy link
Contributor

What Does This PR Do

Allows welding tools to light another person's cigarette by targeting the mouth whilst there is an unlit cigarette perched between their lips.

Why It's Good For The Game

When someone asks you if you have a light, you can nod with confidence as you pull out your trusty welder like a true badass.

Testing

A number of skrell were given cigarettes. They then lit each other's cigarettes with a welding tool that was also provided.

No skrell were harmed in the making of this PR.

Changelog

🆑
add: Unlit cigarettes in the mouth slot can be lit by another person using a lit welder when targeting the mouth.
/:cl:

You can light other people's cigarettes with welders wooo!
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Jan 28, 2024
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
@Probablyjay19
Copy link
Contributor

Almost 100% positive you can already do this by opening up the strip menu and using the welder on the strip option for the cigarette, but this is simpler. Bravo.

@Fordoxia
Copy link
Contributor Author

Fordoxia commented Feb 1, 2024

Almost 100% positive you can already do this by opening up the strip menu and using the welder on the strip option for the cigarette, but this is simpler. Bravo.

You cannot. Trying this will simply attempt to strip the cigarette.

Source: I just tried to do this on master branch and it didn't work.

@farie82 farie82 added Fix This PR will fix an issue in the game Tweak This PR tweaks something ingame and removed Fix This PR will fix an issue in the game labels Feb 6, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 6, 2024
@Henri215 Henri215 requested a review from lewcc February 13, 2024 12:00
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally and removed -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Feb 18, 2024
Co-authored-by: S34N <12197162+S34NW@users.noreply.github.com>
Co-authored-by: DGamerL <108773801+DGamerL@users.noreply.github.com>
@S34NW S34NW merged commit 0a2669f into ParadiseSS13:master Mar 1, 2024
11 checks passed
@Fordoxia Fordoxia deleted the WeldingLighter branch March 1, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants