Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the lavaland outpost causing CI to fail #23431

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Fixes the lavaland outpost causing CI to fail #23431

merged 5 commits into from
Dec 1, 2023

Conversation

DGamerL
Copy link
Member

@DGamerL DGamerL commented Dec 1, 2023 •
edited
Loading

What Does This PR Do

Changes access helpers from all to any, which caused CI to fail sometimes

Why It's Good For The Game

This shouldn't make CI fail

Testing

Let's check the CI, code compiled

Changelog

NPFC

@DGamerL DGamerL changed the title Also an easy fix Fixes the lavaland outpost causing CI to fail Dec 1, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Map Edit This PR will modify a map labels Dec 1, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added the MetaStation This PR will edit the map MetaStation (Cerebron) label Dec 1, 2023
@S34NW S34NW added Fix This PR will fix an issue in the game and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Dec 1, 2023
@S34NW S34NW merged commit 489d83c into ParadiseSS13:master Dec 1, 2023
11 checks passed
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Dec 1, 2023
@DGamerL DGamerL deleted the Fixes-CI-failing-a-LOT branch December 1, 2023 15:21
Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
@DGamerL @Oyu07
Fixes the lavaland outpost causing CI to fail (ParadiseSS13#23431)
d40cd55 
* Also an easy fix

* Adds the CI addition

* I can't Engrish

* Fixes Metastation

* Oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S34NW S34NW S34NW approved these changes

Assignees
No one assigned
Labels
-Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Fix This PR will fix an issue in the game Map Edit This PR will modify a map MetaStation This PR will edit the map MetaStation (Cerebron)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DGamerL @S34NW @ParadiseSS13-Bot