Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the ability to keybind click() triggers #23395

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

GDNgit
Copy link
Contributor

@GDNgit GDNgit commented Nov 28, 2023

What Does This PR Do

Adds the ability to keybind click options

Why It's Good For The Game

Middle click is the big one here, lets trackpad users more easily point. I think having the ability to just get a examine/pull button is good

Testing

Used them in game
realized rev is silly

Changelog

🆑
add: Click combinations can now be binded to a button
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 28, 2023
@farie82 farie82 added the Tweak This PR tweaks something ingame label Nov 29, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added Testmerge Requested This PR has a pending testmerge request -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 29, 2023
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Jan 6, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Jan 14, 2024
code/_onclick/click.dm Show resolved Hide resolved
code/datums/keybindings/click_keybindings.dm Outdated Show resolved Hide resolved
Co-authored-by: Ryan <80364400+Sirryan2002@users.noreply.github.com>
Copy link
Contributor

@Sirryan2002 Sirryan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine? I don't know enough about click() stuff to say anything other than that

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Jan 20, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 21, 2024
@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Feb 15, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Feb 17, 2024
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has worked well enough on live for it to go in

@S34NW S34NW merged commit 599f645 into ParadiseSS13:master Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Testmerge Requested This PR has a pending testmerge request Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants