Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dualsaber great again #23361

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

HMBGERDO
Copy link
Contributor

@HMBGERDO HMBGERDO commented Nov 25, 2023

What Does This PR Do

This PR adds percentage armor penetration to dualsabers

Why It's Good For The Game

dualsabers are currently worse than single esword against armor. This shouldnt be that. Someone forgot to add this variable to dualsaber when armour refactor PR(#18547) was made

Testing

compiled, cut some nerds with both dualsaber and esword

Changelog

🆑
fix: fixed deswords not having armor penetration
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 25, 2023
@farie82 farie82 added the Fix This PR will fix an issue in the game label Nov 29, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 29, 2023
@lewcc lewcc merged commit 28e54f9 into ParadiseSS13:master Nov 29, 2023
Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Fix This PR will fix an issue in the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants