Fixes some chat messages with the arcade prize machine #23354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR has been put on hold as your GitHub account is not linked to a Paradise forums account. Please link your account at https://www.paradisestation.org/forum/custom/link_github_account.php Headcoders may ignore this in specific circumstances (Minor fix PR, trusted contributor from another codebase, anything at their discretion) |
Henri215
reviewed
Nov 24, 2023
Sirryan2002
approved these changes
Nov 26, 2023
Burzah
approved these changes
Nov 26, 2023
lewcc
approved these changes
Nov 29, 2023
Oyu07
pushed a commit
to Oyu07/Paradise
that referenced
this pull request
Jan 2, 2024
…23354) * fixes the chat message * addresses review * addressing review 2 electric boogaloo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Fixes chat messages meant just for the user going to everyone within view.
Why It's Good For The Game
Generally makes more sense, not everyone needs to see that you're too arcade poor to afford the water balloon
Testing
Fired up the server with 2 clients, made sure only the machine user could see it when the purchase went through and when it didn't
Changelog
🆑
fix: Arcade reward machine no longer broadcasts your lack of tickets to the world
/:cl: