No more runtimes when a limb takes damage with no owner #23341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
requested changes
Nov 23, 2023
Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Contrabang
approved these changes
Nov 23, 2023
Burzah
approved these changes
Nov 24, 2023
lewcc
approved these changes
Nov 29, 2023
Oyu07
pushed a commit
to Oyu07/Paradise
that referenced
this pull request
Jan 2, 2024
…#23341) * Update organ_external.dm * Update code/modules/surgery/organs/organ_external.dm Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com> --------- Co-authored-by: Contrabang <91113370+Contrabang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Checks for an owner before checking droplimb from max damage on limbs since limbs don't droplimb with no owner and it causes null check
Why It's Good For The Game
bugs bad
Testing
Compiled, now has checks protected via the owner check
Changelog
🆑
fix: Limbs no longer runtime when taking damage with no owner
/:cl: