Lobotomizes the brain from /mob/living/carbon #23320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contrabang
reviewed
Nov 21, 2023
S34NW
approved these changes
Nov 29, 2023
Oyu07
pushed a commit
to Oyu07/Paradise
that referenced
this pull request
Jan 2, 2024
* find and replace. this causes zero errors. * there was one error * repathing * minor emote repathing as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
Repaths brains under
/mob/living/brain, instead of/mob/living/carbon/brain. This came up yesterday and I think it's a sensible move that's surprisingly clean and easy to do.The only real change that I needed to make beyond repathing was to remove a useless override that kept them from needing to breathe.
Why It's Good For The Game
Brains being under carbon seems like more of a leftover than anything, and this should keep it from causing any problems down the line. This is also a clean cut, so I don't expect it to cause any player-facing changes
Testing
Compiled, loaded in, put a brain in an MMI, nothing seemed to change.
Again, since there is nothing in brain code that directly relies on carbon code (beyond possibly overrides), I expect little to change. This is probably worth a TM, however.
Changelog
NPFC