Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap crackle and pop, new changeling sounds #23238

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

ItsMarmite
Copy link
Contributor

@ItsMarmite ItsMarmite commented Nov 12, 2023

What Does This PR Do

Armblade, Tentacle, Chitinous Mass, and Organic shield will now make bone snapping noises when equipped and de-equipped.

Armblade now has a unique sound for attacks, made by silverillusionist (https://freesound.org/people/SilverIllusionist/sounds/472689/)

Resonant screech now has a new sound made from sounds used in this PR.
(#19099)

Why It's Good For The Game

I want changelings to be creepier. Body horror changelings good. A lot of these abilities already mention bones cracking, so lets hear them crack. As for the armblade/resonant changes, I felt the sound was better.

Images of changes

2023-11-12.17-51-28.mp4

Testing

A good amount of button pressing.

Changelog

🆑
tweak: Armblade, Tentacle, Chitinous Mass and Organic shield now make the sound of bones cracking when activated and deactivated.
soundadd: Adds a new sound for resonant screech.
soundadd: Adds a new on hit sound for armblades.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally Sound This PR modifies the game sound labels Nov 12, 2023
@AffectedArc07
Copy link
Member

Get me my rice crispies

@spacegeese
Copy link
Contributor

maybe make the screams louder and more sudden? it sorta sounds like the changeling is running very fast while screaming or he's in a cave or something, it's good for ambient ling sounds but the shrieks would benefit from being shriekier

@farie82 farie82 added the Tweak This PR tweaks something ingame label Nov 22, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 22, 2023
ItsMarmite and others added 7 commits November 22, 2023 18:53
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Nov 27, 2023
@Burzah Burzah requested a review from Henri215 November 30, 2023 14:50
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 30, 2023
@S34NW S34NW merged commit 323a91c into ParadiseSS13:master Dec 6, 2023
Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
* ree

* aaaaaaa

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

* Update code/modules/antagonists/changeling/powers/mutations.dm

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>

---------

Co-authored-by: Henri215 <77684085+Henri215@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Sound This PR modifies the game sound Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants