Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Species Blurbs in the Character Preference Menu #23229

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

OctusGit
Copy link
Contributor

@OctusGit OctusGit commented Nov 11, 2023

What Does This PR Do

Connects blurbs from species.dm to be read onto the character menu. Allowing for general information about said species.

  • Review old species blurbs for rewrites or tweaks.
  • Write blurbs for species without one.
  • Get Lore Team majority approval for blurbs.

Why It's Good For The Game

The biggest issue I've found with paradise is its lack of innovation to teach lore towards new or old players, without the use of third party extensions like the wiki. This allows us to help new players who are making characters easily be given a summary of the species they choose, as well as helping bridge the interest of lore, and game together without disrupting the established order. Species lore is the most important part for alot of people, so it deserves some support.

Images of changes

z2E0nvxCBI

Testing

Works, but WIP

Changelog

🆑 Octus GDNgit
add: Added species lore blurbs in the character menu
/:cl:

code/modules/client/preference/character.dm Outdated Show resolved Hide resolved
code/modules/client/preference/preferences.dm Outdated Show resolved Hide resolved
OctusGit and others added 2 commits November 11, 2023 16:13
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
@OctusGit OctusGit marked this pull request as draft November 11, 2023 22:15
@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 11, 2023
@SteelSlayer SteelSlayer added the Feature This PR is a new addition to the game label Nov 12, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Nov 12, 2023
OctusGit and others added 2 commits November 14, 2023 13:43
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
@OctusGit OctusGit marked this pull request as ready for review November 21, 2023 07:12
@OctusGit
Copy link
Contributor Author

Should be ready, if anyone on lore has an objection feel free to use channel on discord to communicate.

Copy link
Contributor

@Sirryan2002 Sirryan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for code

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 25, 2023
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some grammar suggestions.

code/modules/mob/living/carbon/human/species/vox.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/species/unathi.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/species/plasmaman.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/species/machine.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/species/kidan.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/human/species/drask.dm Outdated Show resolved Hide resolved
@S34NW S34NW merged commit 2e860a5 into ParadiseSS13:master Dec 6, 2023
Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
)

* LOREEEEEEEEE

* Update code/modules/client/preference/character.dm

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* Update code/modules/client/preference/preferences.dm

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>

* Update code/modules/client/preference/preferences.dm

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* EVERY FUCKING BLURBBBBB

* Apply suggestions from code review

Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>

* REWORKED THE HUMAN TEXT

* Update human_species.dm

* skrell lore tweak

---------

Co-authored-by: GDN <96800819+GDNgit@users.noreply.github.com>
Co-authored-by: Luc <89928798+lewcc@users.noreply.github.com>
@OctusGit OctusGit deleted the species-description branch January 11, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Feature This PR is a new addition to the game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants