Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CereStation eligible for random map selection on 60+ players only #23206

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

dearmochi
Copy link
Contributor

What Does This PR Do

  • Adds min_players_random variable (default 0) to /datum/map. Used to filter out potential map picks during random map selection (that is, random map day) if the player count at the time of selection does not exceed it
  • Sets the above variable to 60 for CereStation. I picked that number kind of randomly, so I'm open to adjusting it

Why It's Good For The Game

On random map days, any map can currently be picked which is fine for normal pop. The problem is when CereStation (a large map) is picked during off hours where departments are rarely filled. At the time of writing, I just saw it get picked and the round started with 12 players in-game. That's a ridiculously low number

This doesn't solve the voting issue, but it should alleviate some of the frustration of having to deal with that map with hardly anyone online

Testing

Outputted the list of possible map picks at 60 then 0

Changelog

🆑
tweak: CereStation may only be randomly picked if there are 60 players online or more on round end
/:cl:

@meow20
Copy link
Contributor

meow20 commented Nov 9, 2023

literally solved world hunger in one pr

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Nov 9, 2023
Copy link
Contributor

@Sirryan2002 Sirryan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for code

@SteelSlayer SteelSlayer added the Tweak This PR tweaks something ingame label Nov 12, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 12, 2023
@Danchi299
Copy link
Contributor

everyone was saying "it won't work", "map is selected round end", "there is big players difference between last round and next round".
well it's better to at least try something

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting approval This PR is waiting for approval internally labels Nov 14, 2023
Copy link
Member

@S34NW S34NW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not perfect, but better than what we currently have

@S34NW S34NW merged commit 86d28cc into ParadiseSS13:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Tweak This PR tweaks something ingame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants