Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changeling Headslug Buff + Incubation Changes #23025

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

ItsMarmite
Copy link
Contributor

@ItsMarmite ItsMarmite commented Oct 25, 2023

What Does This PR Do

Marginally buffs the health of headslugs, and makes them deal stamina damage on bite.

  • 50>60 HP.

  • Last resort can now be used when incapacitated or dead.

  • 30-35 stamina damage per bite.

Time for incubation has been lowered to 60 seconds for dead bodies, and 120 seconds for living people.

In later stages of incubation, victims will now actually go into crit and start taking heavy stamina damage.

Why It's Good For The Game

We're gradually moving away from changelings dying and reviving constantly in combat and death warring security, its best we give changelings a more interactive 'out', previous headslug buffs have made them viable but they're still quite squishy and struggle to live past popping out of the vent.

Testing

I'm sick and tired of using headslug, I've had to tweak numbers so much.

Changelog

🆑
tweak: Buffs headslugs, they're now tougher and deal stamina damage.
tweak: Lowers incubation time for changeling eggs.
tweak: Later stages of incubation or changeling eggs is now deadlier for the victim.
tweak: Last resort now functions when dead or incapacitated.
/:cl:

@HMBGERDO
Copy link
Contributor

HMBGERDO commented Oct 25, 2023

headslugs are already very powerful
with high speed, they run through doors and hide under other obstacles
they pass lasers, if you dont directly click it(and its not trying to avoid laser)
i've seen the same changeling escape 4 times via headslug on box chapel with 4 officers around all the time
giving it more health and staminacrit attacks isnt needed by my sight

is there any current statistics for headslug survive/death rate?

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Oct 25, 2023
@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Oct 25, 2023
@ppi13
Copy link
Contributor

ppi13 commented Oct 25, 2023

Both the health and damage increase is good, however I am uncertain about the movement speed ontop, since they can so easily crawl under doors.
Damage numbers might be a bit high, but considering they lose all other utility at that point, that is probably less of an issue.
Short term this should make headslugs both stronger and more viable, and eventually inspire a change in the changeling gameplayloop.

@farie82 farie82 added the Balance This PR will modify how effective something is or isnt label Oct 26, 2023
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Oct 26, 2023
@Rurik123
Copy link

Incubation and HP change is fine.

Stamina is a interesting idea, although 30 feels too much? I'd wait for another opinion on that.

Not in favor of movement speed matching a human, given that we gave headslugs the ability to go under airlocks without delay.

@matttheficus
Copy link
Contributor

Ditto as Rurik - with the insta-doorslides, i think they should still be a BIT slower.

Stamina is also interesting, probably okay at 30 but can always lower it if need be.

@ItsMarmite
Copy link
Contributor Author

I'll go through this PR tomorrow and make requested changes.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting approval This PR is waiting for approval internally labels Nov 6, 2023
@Henri215
Copy link
Contributor

Henri215 commented Nov 9, 2023

I'll go through this PR tomorrow and make requested changes.

Update the PR description, it no longer tweaks the speed

Copy link
Contributor

@Henri215 Henri215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lewcs good to me

@ItsMarmite
Copy link
Contributor Author

Requested changes made.

@ItsMarmite
Copy link
Contributor Author

Based off of a conversation in coding chat Last resort now functions when dead or incapacitated.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 19, 2023
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing, code looks good otherwise.

code/modules/mob/living/simple_animal/hostile/headslug.dm Outdated Show resolved Hide resolved
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting merge This PR is ready for merge labels Nov 20, 2023
Copy link
Member

@DGamerL DGamerL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lewc's request done, LGTM

@Burzah Burzah requested a review from lewcc November 30, 2023 14:43
Copy link
Contributor

@lewcc lewcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. the marmite.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting merge This PR is ready for merge and removed -Status: Awaiting review This PR is awaiting review from the review team labels Nov 30, 2023
@lewcc lewcc merged commit b5832cc into ParadiseSS13:master Nov 30, 2023
@Dafrek
Copy link
Contributor

Dafrek commented Dec 13, 2023

Making head slugs able to stamcrit someone in fewer hits than it takes for them to be harmbatonned to death while having a much harder hitbox to hit on top of all the other buffs from this PR and others seems a bit much, especially when it only costs 2 out of 20 cling points to get the last resort ability. The insane amount of value you get from this ability now is not reflected in the price imo.

Being able to last resort while dead essentially seems like it makes this a no-brainer meta-pick since you will always be able to use it right before you are permanently killed. I'm not a fan of one of the least fun cling abilities to play against (and arguably one of the least fun abilities to use) being a meta pick.

Oyu07 pushed a commit to Oyu07/Paradise that referenced this pull request Jan 2, 2024
* cling burger

* slowpoke

* its aliiiive

* cycle it up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting merge This PR is ready for merge Balance This PR will modify how effective something is or isnt Requires Wiki Update Useful for Wiki Contributers to search for things that need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.