Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead AIs are still forced to attempt to announce new arrivals #28143

Closed
1 task done
TravisAngeI opened this issue Jan 27, 2025 · 0 comments · Fixed by #28170
Closed
1 task done

Dead AIs are still forced to attempt to announce new arrivals #28143

TravisAngeI opened this issue Jan 27, 2025 · 0 comments · Fixed by #28170
Labels
Bug This is a bug in our game code

Comments

@TravisAngeI
Copy link

TravisAngeI commented Jan 27, 2025

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1647

Issue Description

An AI player who had died that round was still being forced to say new arrivals, and the Arrivals Announcement Computer did nothing

What did you expect to happen?

For the Arrivals Announcement Computer to activate

What happened instead?

The Dead AI was spouting off new-arrivals in dchat, and newly arrivals were not being announced by the Arrivals Announcement Computer

Image

Image

Why is this bad/What are the consequences?

Newly arrivals should be announced, and dead AIs should not be forced to speak

Steps to reproduce the issue.

  1. Be AI
  2. Die
  3. Have a new person arrive while you're in dchat
  4. Issue happens

When did the problem start happening?

Not sure at all, I've only seen this started to happen recently but I'm not sure what could of caused it

Extra information

No response

Relevant log output/runtime error

@1080pCat 1080pCat added the Bug This is a bug in our game code label Jan 28, 2025
@1080pCat 1080pCat moved this to Cause Unknown in Paradise Station Issue Tracker Jan 28, 2025
asciodev added a commit to asciodev/Paradise that referenced this issue Jan 29, 2025
PR fixes ParadiseSS13#28143

Adds a `stat` check lost in an earlier migration from
`GLOB.alive_mob_list` to `GLOB.ai_list`, to ensure dead AIs aren't added
to the list of announcers.
github-merge-queue bot pushed a commit that referenced this issue Jan 29, 2025
PR fixes #28143

Adds a `stat` check lost in an earlier migration from
`GLOB.alive_mob_list` to `GLOB.ai_list`, to ensure dead AIs aren't added
to the list of announcers.
@github-project-automation github-project-automation bot moved this from Cause Unknown to Resolved issues in Paradise Station Issue Tracker Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug in our game code
Projects
Status: Resolved issues
Development

Successfully merging a pull request may close this issue.

2 participants