Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added icons for Mattermost #849

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Added icons for Mattermost #849

merged 1 commit into from
Nov 19, 2017

Conversation

theohennessy
Copy link

No description provided.

@SmartFinn
Copy link
Member

Nice work!

There are several remarks:

  1. All objects should be rounded to whole numbers and align to pixels (use View → Page Grid in Inkscape).

pixels_alingment

  1. 48px icon is missing
  2. Use object opacity (20%) instead fill-opacity for shadows.

@varlesh
Copy link
Contributor

varlesh commented Oct 27, 2017

@SmartFinn Надо в tools наверн добавить этот скрин

@SmartFinn
Copy link
Member

@varlesh лучше конечно собрать все подобные ошибки и оформить в виде wiki. Да и сам guide туда перенести, а в CONTRIBUTING.md сделать ссылку на него.

@theohennessy
Copy link
Author

thanks for the feedback. Will update accordingly !

@varlesh varlesh merged commit e2194d1 into PapirusDevelopmentTeam:master Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theohennessy @SmartFinn @varlesh