Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trackma icon #438

Merged
merged 3 commits into from
May 10, 2017
Merged

Trackma icon #438

merged 3 commits into from
May 10, 2017

Conversation

w3r3wolv3s
Copy link
Contributor

Adding Trackma icon

@SmartFinn
Copy link
Member

Awesome icon, but have some problems.

  1. Icons of 24px and 48px are too large. Fix only the 48px icon and you can use it for 22px and 24px icons simply dividing by 2. Or you can use the 22px icon as a source for 24px and 48px icons.

    Recommended sizes:

    56px for 64px icons
    40px for 48px icons
    28px for 32px icons
    20px for 24px icons
    20px for 22px icons
    16px for 16px icons

  2. Icons of 22px, 24px, 48px and 64 have wrong height of outline. It must be 1px for 48px/64px, and 0.5px for 22px/24px. Also, an opacity of the outline must be 20 for light icons (10 for dark).

@w3r3wolv3s
Copy link
Contributor Author

Will fix these issues and resubmit.

@w3r3wolv3s
Copy link
Contributor Author

Can you clarify request #2? By "outline" do you mean the highlight at the top, or the drop shadow on the bottom? Both are currently set to 20% opacity.

@SmartFinn
Copy link
Member

Yes, I mean the highlight at the top.

Wrong:
screenshot from 2017-05-10 08-25-52

Right (changed the opacity and height):
screenshot from 2017-05-10 08-26-49

@w3r3wolv3s
Copy link
Contributor Author

I believe I have this corrected now. I pushed the new version to my repository.

@SmartFinn SmartFinn merged commit ae51953 into PapirusDevelopmentTeam:master May 10, 2017
SmartFinn added a commit that referenced this pull request May 10, 2017
@SmartFinn SmartFinn mentioned this pull request May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants