Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for Ente Auth #3921

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Conversation

wilwarindi
Copy link
Contributor

@wilwarindi wilwarindi commented Jan 21, 2025

Add icon and (symlink for the Flathub release) for Ente Auth
closes #3784

enteauth@64x64

@morganist
Copy link
Member

@wilwarindi considering the shade of white, you should use the one you think fits the most. I don't think it is necessary to use #e4e4e4 as much as possible anymore. The variant you've proposed in #3912 is great!

@morganist
Copy link
Member

icon request #3839 is a duplicate, refer to #3784

@achadwick
Copy link
Contributor

If it was mine, I'd make the inner padlock a cutout in the logo, rather than a repeat of the base's colour as a new raised surface on top of the white shield design. That way, you'd have a shadow to help delineate the narrower forms at the top of the padlock.

Inkscape's Path → Difference for the win ;)

@morganist
Copy link
Member

@achadwick now that you say this, a white logo without a purple base shape could work too, and it won't look like the usual square or a circle so much of modern app icons use. hmm..

@wilwarindi
Copy link
Contributor Author

Yay!
@achadwick I'll be honest, the difference function is a mystery to me. I know you tried to explain it before, but it went over my head. Feel free to change the files how you see fit; it'll probably look good, and I can always update the PR with your changes.

@morganist
Copy link
Member

please, make shadows and highlights on the purple background 1px thick, as per guidelines.

@wilwarindi
Copy link
Contributor Author

@morganist Done.
Also, @achadwick I figured out how and why to use the Difference function.

@achadwick
Copy link
Contributor

Also, @achadwick I figured out how and why to use the Difference function.

Sorry I didn't get back to you earlier! Been busy with other things lately.

I'm hoping to document specifically how to make Papirus-ish top highlights and shadows for groupings of any types of object, but for now the Inkscape docs for the Boolean path operations should be helpful :)

@achadwick
Copy link
Contributor

@wilwarindi
Quick visual check on these: they look to be nicely aligned now, and no transforms on groups!

@morganist I think they're ready for merge

@morganist
Copy link
Member

morganist commented Jan 29, 2025

I added a new symlink with the name from the icon request as well as fixed a few non-pixel-perfect nodes and added a highlight, all great now.

@morganist morganist merged commit 2407de3 into PapirusDevelopmentTeam:master Jan 29, 2025
1 check passed
@wilwarindi wilwarindi deleted the enteauth branch February 1, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon request] Ente Auth
3 participants