-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Timestripe icons #3592
Add Timestripe icons #3592
Conversation
Ha, it's the strangest way to add the light outline that I have seen. You may keep it, but it less maintainable. Also, |
Initially, I made the outline a path like on most other icons in Papirus. However, using a simple rounded rectangle takes fewer characters in SVG, and it also seemed more maintainable as it's easier to change the radius, for example. As for the color, I actually did my own research, looking for the darkest base color among Papirus icons. Most icons do have the darkest color at 31% lightness ( Other icons with the base color at 25% lightness are angrysearch, apollo-studio, plex, tidal, pacseek, and a dozen of others too. Am I misunderstanding what the base color is here? |
Updated the base color to |
I can't easily remove the shadows and the light outlines with
These may be exceptions, or these icons were added before HIG. |
Thanks for the guidelines. I will follow them more closely in this and my future contributions. I will change the shadow and light outline as you suggested. |
@yevklim the shadows for inner object are missing too. Could you added it with unset fill and |
I made changes following the guidelines and your comments. Hope I didn't miss anything. Please review. |
- Reduce opacity of shadows for inner objects - Replace bright white color with #e0e0e0e - Add missing `ry=` attributes for rounded rectangles - Replace rounded square with squircle for 16-24px icons to unify the shape - Replace shadow path object with rect - Fix blurred edge for inner object in 48px icon
@yevklim Thanks. This is a very good icon for the first time. |
Timestripe is a time-management web application with the official website at https://timestripe.com.
On a desktop, it can be installed as a PWA in most Chromium-based browsers.
With this PR, I'm adding icons for Timestripe and icons-symlinks for the PWA for Brave, Chrome, and Vivaldi.
The icons of sizes 16x16, 22x22, and 24x24 look different from the higher-resolution icons because that's what the official icons of that size look like.