Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VSCodium icon #3402

Merged

Conversation

cavcrosby
Copy link
Contributor

Fulfills #3401.

@SmartFinn
Copy link
Member

Thanks for the contribution. There are a couple issues with this icon:

  1. Missing margins, without it the icons feel much bigger than others. See Basic concepts and templates at tools/work/Papirus/apps
  2. Papirus icons shouldn't use any gradient.

@cavcrosby cavcrosby force-pushed the update-vscodium-icon branch from 20a0647 to 9449eaa Compare April 3, 2023 15:01
@cavcrosby
Copy link
Contributor Author

cavcrosby commented Apr 3, 2023

I believe I have addressed the points you've made @SmartFinn.

Will add that I decided to make the icon color blue based on what's given in the example colors SVG (tools/work/examples-papirus.svg), I think this color is brighter and "pops" better in appearance vs the original.

@cavcrosby cavcrosby force-pushed the update-vscodium-icon branch from 9449eaa to 420f85f Compare April 7, 2023 13:08
@SmartFinn
Copy link
Member

Sorry for the late reply.

There is one major issue with these icons, edges of objects should be snapping to the pixel grid. 48px icon is mostly ok, but others icons, especially the 16-32px are blurry.

Here are a couple examples where is ok, and where is bad:

image
image
image

@hervyqa
Copy link
Contributor

hervyqa commented Apr 25, 2023

@cavcrosby great work!.
i prefer to keep the white circle, but inside it with the new blue logo.

@cavcrosby cavcrosby force-pushed the update-vscodium-icon branch from 420f85f to 7e5c97f Compare May 6, 2023 16:28
@cavcrosby
Copy link
Contributor Author

In this latest attempt, I've tried to pixel align the edges of objects to the grid in some manner, but unfortunately the geometric shaping of the icon makes perfecting pixel alignment about impossible. If that isn't acceptable, then I can close the PR and let someone else take a crack at it.

@SmartFinn
Copy link
Member

@cavcrosby thank you for your patience 😄 It looks a good enough. I'll merge it when I'll have time to fix minor issues.

@SmartFinn SmartFinn merged commit 0e8d73a into PapirusDevelopmentTeam:master May 8, 2023
SmartFinn added a commit that referenced this pull request May 8, 2023
@cavcrosby cavcrosby deleted the update-vscodium-icon branch May 8, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants