Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon qprompt #3350

Merged
merged 1 commit into from
Dec 9, 2022
Merged

icon qprompt #3350

merged 1 commit into from
Dec 9, 2022

Conversation

hervyqa
Copy link
Contributor

@hervyqa hervyqa commented Dec 7, 2022

Original icon:
qprompt

Papirus icon:
qprompt

@SmartFinn
Copy link
Member

Nice work!

But I see a major issue on all sizes of the icon:

Edges of objects should be alignment to pixel grid (use View → Page Grid in Inkscape) to avoid blurring on Low DPI screens.

Bad

image

Good

image

Tip: Take a hexagon from an existing icon with proper alignment, shadows and highlights.

@hervyqa
Copy link
Contributor Author

hervyqa commented Dec 8, 2022

But I see a major issue on all sizes of the icon.

please review again. thank you..

@SmartFinn
Copy link
Member

SmartFinn commented Dec 8, 2022

Thanks!

There are 3 minor issues left:

  1. Highlights and shadows on 22px/24px icons should be 0.5px instead of 1px
  2. The opacity of highlight should be reduced to 10% on black objects
  3. The opacity of shadows should be reduced to 10% on black objects

See a4fdcac

@hervyqa
Copy link
Contributor Author

hervyqa commented Dec 9, 2022

done..

  • Highlights and shadows on 22px/24px icons should be 0.5px instead of 1px
  • The opacity of highlight should be reduced to 10% on black objects
  • The opacity of shadows should be reduced to 10% on black objects

@SmartFinn SmartFinn merged commit c87e482 into PapirusDevelopmentTeam:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants