Fixed installation issue when target directory contains spaces #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Likewise fixed the same issue when uninstalling. The issue was rooted in the fact that "DESTDIR" and "PREFIX" weren't quoted, which caused the 'mkdir', 'cp' and 'rm' commands to treat any spaces in directory names as separate arguments.
hwittenborn
commented
Aug 22, 2021
|
|
||
| uninstall: | ||
| -rm -rf $(foreach icon_theme,$(ICON_THEMES),$(DESTDIR)$(PREFIX)/share/icons/$(icon_theme)) | ||
| - rm -rf $(foreach icon_theme,$(ICON_THEMES),"$(DESTDIR)$(PREFIX)/share/icons/$(icon_theme)") |
There was a problem hiding this comment.
Ignore the space that was added at the beginning of this line. I think I just unintentionally added it due to it looking a bit off to me.
|
Thanks. I think I did it deliberately because paths to icons with spaces are not valid. Now I see that in the case of packaging, this approach is incorrect. |
SmartFinn
added a commit
that referenced
this pull request
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, doing something like
make install DESTDIR="${PWD}/tmp dir"would not act correctly due totmp dircontaining spaces.The main issue comes into play when I was doing testing for some packaging. I always copy the directory before doing testing, and Nautilus (which I use as my GUI file manager) names the copied directory
foldername (copy), which thus causes the issue this PR aims to solve.If it's at all feasible, it would be nice if a new release with this fix incorporated could be made as well.