Changed godot.svg icon #2723
Merged
Changed godot.svg icon #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thx for PR, but you not use pixel align (it's our HIG). Compare with Papirus original icon (look at the teeth). Your lines blured. |
|
Thank you so much for your advice. Now it's supposed to be all pixel perfect right now. Do I have to make another PR if they are okay, btw? Here are how they look like: 16x16 22x22 24x24 32x32 48x48 64x64 |
SmartFinn
added a commit
that referenced
this pull request
Jun 21, 2021
- replace fill-opacity with opacity - fix vertical alignment
|
Hahaha, Now I see that you have already emerged it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attemp to improve the appearance of the Godot game engine icon because, in my opinion, it was painful to see. I tried to adjust most elements to the grid, and it was quite hard (old icon wins in here). Nevertheless, I think that this new design is good enough: colors are the same, most of the elements are adjusted, shape more similar compared with the original logo, and padding and 'shadows' are respected. Hope it is worth it.
Current icon (64x64)
New icon (64x64)
