Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openMW-cs, added snapd icon. #2413

Closed
wants to merge 4 commits into from
Closed

Fix openMW-cs, added snapd icon. #2413

wants to merge 4 commits into from

Conversation

FraxinusAcer
Copy link

Fix. Removed the white circle on the gear for dark themes, and added shadows to the icon.

@FraxinusAcer
Copy link
Author

[Icon request] folder-snap #2305

Closed?

@FraxinusAcer
Copy link
Author

[Icon request] The Fertile Crescent #2396

Done. As i see. But its app dnt uses desktop-file.

@SmartFinn
Copy link
Member

SmartFinn commented Oct 26, 2020

Thanks for the contributions!

All of these icons have a couple of major issues:

  1. Almost all objects on the icons did not align to the pixel grid (edges of objects are blurred)
  2. Major of the icons do not have margins like other Papirus icons (see examples in work/Papirus/apps)

Also, the author of #2305 issue requests a folder icon with the Snapcraft bird logo, not just a logo (see examples in work/Papirus/places)

I would be glad if you solve these issues.

@FraxinusAcer
Copy link
Author

Thank you for your feedback and quick explanation of the merge request issues.

Unfortunately, I don't understand how to do it, but I have a desire to do it.

Do I need to delete this request?

@FraxinusAcer FraxinusAcer changed the title Edit openMW-cs - added shadows and transparency. Fix openMW-cs, added snapd icon. Oct 29, 2020
@FraxinusAcer FraxinusAcer reopened this Nov 8, 2020
SmartFinn added a commit that referenced this pull request Jan 11, 2021
@SmartFinn
Copy link
Member

Sorry for that delay. I think we can close this PR. folder-snap icon is already added and openmw-cs icon is fixed now.

@SmartFinn SmartFinn closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants