Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some Fixed types with Threshold in index.theme files #2301

Closed
wants to merge 1 commit into from

Conversation

SmartFinn
Copy link
Member

@SmartFinn SmartFinn commented Jun 29, 2020

This PR allows:

  • scaling actions icons 16px to 32px, 22px to 44px, 24px to 48px
  • scaling 32x32/emblems to 64px/96px/128px/160px/192px/224px/256px
  • scaling 48x48/* to 96px/144px
  • scaling 64x64/* to 128px/192px/256px

It fixes the previous behavior that blurring icons because:

  • scaling 24x24/actions icons to 32px/44px
  • scaling 48x48/emblems to 64px/128px/192px/256px
  • scaling 64x64/* to 96px/144px

The changes tested in GNOME and should be tested in other DE before merging.

Details https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

Removed the workaround for 96x96 icon support
@varlesh
Copy link
Contributor

varlesh commented Jun 30, 2020

Tested on KDE & Pantheon. I'm not seen bugs)

@SmartFinn
Copy link
Member Author

Unfortunately Type=Threshold doesn't work as I expected. It doesn't allow scaling 22px to 44px, it allows scaling 48px to 96px, but Type=Fixed do the same. To correct support 44px and other scaling resolutions need to add workaround as I added for 96px. Only the following snippets are incorrect and should be deleted:

[64x64/*]
Context=*
Size=64
Scale=2
MinSize=64
MaxSize=512
Type=Scalable

@SmartFinn SmartFinn closed this Jul 1, 2020
SmartFinn added a commit that referenced this pull request Jul 1, 2020
Removed the workaround for 96x96 icon that was added earlier
SmartFinn added a commit that referenced this pull request Jul 1, 2020
Removed the workaround for 96x96 icon that was added earlier
@SmartFinn
Copy link
Member Author

Scaling to 96px works fine in GTK-based, but not in Plasma Desktop. Neither Type=Fixed nor Type=Threshold. To add the icon resolution in KDE need to add the workaround back. It will be implemented in the very next release.

@SmartFinn SmartFinn mentioned this pull request Jul 5, 2020
@SmartFinn SmartFinn deleted the index_threshold branch July 5, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants