Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon Request] Davmail #844

Closed
thatubuntuguy opened this issue Oct 22, 2017 · 6 comments
Closed

[Icon Request] Davmail #844

thatubuntuguy opened this issue Oct 22, 2017 · 6 comments

Comments

@thatubuntuguy
Copy link

I know I'm being pedantic but davmail is in my system tray and is a bit of an eyesore would be awesome if you guys could make a tray themed icon for davmail.
Thanks

@varlesh
Copy link
Contributor

varlesh commented Oct 23, 2017

davmail

[Desktop Entry]
Version=1.0
Type=Application
Terminal=false
Name=DavMail
Comment=DavMail POP/IMAP/SMTP/Caldav/Carddav/LDAP Exchange Gateway
Exec=/usr/bin/davmail
Icon=/usr/share/icons/davmail.png
Categories=GTK;GNOME;Network;
Keywords=pop;imap;smtp;exchange;owa;outlook
GenericName=DavMail POP/IMAP/SMTP/Caldav/Carddav/LDAP Exchange Gateway

@varlesh
Copy link
Contributor

varlesh commented Oct 23, 2017

Tray icons hardcoded too.
AwtGatewayTray.java:

@SuppressWarnings("Since15")
public class AwtGatewayTray implements DavGatewayTrayInterface {
    protected static final String TRAY_ACTIVE_PNG = "tray2.png";
    protected static final String TRAY_PNG = "tray.png";
    protected static final String TRAY_INACTIVE_PNG = "trayinactive.png";

@thatubuntuguy
Copy link
Author

Sorry! I'm a bit new to this.. I meant a symbolic icon for davmail because it looks totally out of place on the panel...
Thanks..
davmail

@varlesh
Copy link
Contributor

varlesh commented Oct 23, 2017

@thatubuntuguy It's not symbolic icon, this icon hardcoded on binary file and upstream bug. Se my previous comment with source code for tray

@thatubuntuguy
Copy link
Author

ok, how do i implement this..
Thanks

varlesh added a commit that referenced this issue Oct 23, 2017
@varlesh
Copy link
Contributor

varlesh commented Oct 23, 2017

fix your desktop file:
Icon=davmail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants