Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon Request: QtPass #662

Closed
ghost opened this issue Aug 25, 2017 · 8 comments
Closed

Icon Request: QtPass #662

ghost opened this issue Aug 25, 2017 · 8 comments
Labels
completed hardcoded icon request panel

Comments

@ghost
Copy link

ghost commented Aug 25, 2017

Applicon name: QtPass
Icon name: qtpass-icon

sadd
@varlesh
Copy link
Contributor

varlesh commented Aug 25, 2017

@beli3ver This app use tray?

@ghost
Copy link
Author

ghost commented Aug 25, 2017

Yes!

@varlesh
Copy link
Contributor

varlesh commented Aug 25, 2017

oh yes, see this:
https://github.com/IJHack/QtPass/blob/master/src/trayicon.cpp#L14
But Qt5-apps not support by hardcode-tray

@ghost
Copy link
Author

ghost commented Aug 25, 2017

So no icon for this app?

@varlesh
Copy link
Contributor

varlesh commented Aug 25, 2017

For application only, for tray no

@ghost
Copy link
Author

ghost commented Aug 25, 2017

Ok, I will contact the developer, what must he change to get the new tray icon?

@varlesh
Copy link
Contributor

varlesh commented Aug 25, 2017

IJHack/QtPass#318

varlesh added a commit that referenced this issue Aug 25, 2017
@varlesh
icon qtpass-icon #662
a3a35f0
varlesh added a commit that referenced this issue Oct 24, 2017
@varlesh
icon qtpass-tray #662
617fed4
@varlesh
Copy link
Contributor

varlesh commented Oct 24, 2017 •
edited
Loading

@beli3ver tray icon changed on upstream, see IJHack/QtPass@f700b6a

@varlesh varlesh closed this as completed Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed hardcoded icon request panel
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@varlesh