Icon Request: Notify-OSD

[MarekAG]

Application name: Notify-OSD (it's even referenced in your github readme at "manual fixes for Unity")
Icon name: not.png

Rest of notifyconf.desktop:

[Desktop Entry]
Encoding=UTF-8
Version=1.0
Type=Application
Name=NotifyOSD Configuration
Comment=Tool to configure Ubuntu's notify-osd notification system
Categories=GNOME;Applications;Utility;Qt
Exec=notifyosdconf
Icon=/usr/share/notifyosdconf/not.png

not.png:

[SmartFinn]

Icon already exists, but hardcoded. Use hardcode-fixer to fix it.

[MarekAG]

Already tried that, but with no luck. After running fix.sh from hardcode-fixer nothing changes. There's even no output from the script so I don't have any idea what went wrong.

After reverting and executing script one more time I get:

sudo bash fix.sh   
G: Fixing Aptik...
G: Fixing GDebi...
G: Fixing HP Printer...
G: Fixing Nvidia Settings...
G: Fixing Python (v2.7)...
G: Fixing Python (v3.5)...
G: Fixing SQLiteBrowser...
G: Fixing Ubuntu IBus Table Setup...
G: Fixing Ubuntu Web Browser...
G: Fixing Variety...
G: Fixing X-Diagnose...
~~~

It didn't work for Notify OSD, Android Studio and couple more. I'm not sure that we should depend on this script..

[SmartFinn]

I cannot help you, create issue at https://github.com/Foggalong/hardcode-fixer/issues

[SmartFinn]

@MarekAG sorry, my fault. Didn't notice what filename must differ (notifyconf instead notifyosdconf). It should be fixed now.

Don't forget close Foggalong/hardcode-fixer#289

[MarekAG]

@SmartFinn as far as I understand fix.sh icon name was ok. Script gets icon name from https://github.com/Foggalong/hardcode-fixer/blob/master/tofix.csv#L262 where it is "notifyosdconf".
You probably were cheated by their wiki page (which is incorrect IMHO).

[SmartFinn]

@MarekAG you repeated my mistake, tofix.csv has 4 columns ;)

[MarekAG]

@SmartFinn haha you are right.

So icon name is ok, but fix.sh still isn't working. Maybe it's something more on hardcode-fixer side or I'm doing something really wrong.
I was trying to jump to other theme and back to Papirus, restarting computer, updating icons cache, running fix.sh as normal user and also as sudo. Nothing helped. Weird.
It should be:

But it currently is:

[SmartFinn]

@MarekAG check /usr/share/applications/notifyosdconf.desktop file, it must be:

[Desktop Entry]
Encoding=UTF-8
Version=1.0
Type=Application
Name=NotifyOSD Configuration
Comment=Tool to configure Ubuntu's notify-osd notification system
Categories=GNOME;Applications;Utility;Qt
Exec=notifyosdconf
Icon=notifyconf

[MarekAG]

@SmartFinn thanks, after I manually changed "Icon" field it's now ok. But I think that changing that it's hardcode-fixer job.