Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon request] JamesDSP #2810

Closed
acarasimon96 opened this issue Sep 15, 2021 · 8 comments
Closed

[Icon request] JamesDSP #2810

acarasimon96 opened this issue Sep 15, 2021 · 8 comments

Comments

@acarasimon96
Copy link
Contributor

@varlesh
Copy link
Contributor

varlesh commented Sep 15, 2021

tray icon hardcoded:
https://github.com/Audio4Linux/JDSP4Linux/blob/master/src/interface/TrayIcon.cpp#L42

@acarasimon96
Copy link
Contributor Author

Will report that to the Hardcode Tray project. Thanks.

@varlesh
Copy link
Contributor

varlesh commented Sep 15, 2021

no, icon on binary

@acarasimon96
Copy link
Contributor Author

acarasimon96 commented Sep 15, 2021

Do you mean by the tray icon is part of the binary and therefore impossible for Hardcode Tray to modify it?

@varlesh
Copy link
Contributor

varlesh commented Sep 15, 2021

Yes

@acarasimon96
Copy link
Contributor Author

That leaves an opportunity for me to file an issue in the upstream repo, similar to how Barrier didn't support themes for tray icons initially.

varlesh added a commit that referenced this issue Sep 15, 2021
@varlesh
Copy link
Contributor

varlesh commented Sep 15, 2021

QIcon::fromTheme("jamesdsp-tray", QIcon(":/icons/icon.png"))

@varlesh
Copy link
Contributor

varlesh commented Sep 16, 2021

tray icon added:
Audio4Linux/JDSP4Linux@dbc19d2

@varlesh varlesh closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants