New classes

[varlesh]

Ok guys. We support more De's and earlier adhered to the concept monochrome tray icons wigh 2 colors:

• ColorScheme-Text
• ColorScheme-Highlight
  
  But now it's not enough and we are at a loss.
  Our main DE's - GNOME (GTK) & KDE (Qt) but the have differen classes for staus:
  GNOME have classes:
• warning (Yellow/Orange)
• error (RED)
• success (GREEN)

KDE have classes:

• ColorScheme-NegativeText (RED)
• ColorScheme-PositiveText (GREEN)
• ColorScheme-NeutralText (YELLOW/ORANGE)
• ColorScheme-Highlight (BLUE)

As you see we have only one problem use succes status as ColorScheme-PositiveText or ColorScheme-Highlight.
Yes... yes... we lost monochrome accent color, but can have more variation for status.
OK. Now we dispute about Battery icon and we can't decide what to do:
Now we have this:

Future @SmartFinn version:

Future @varlesh version:

[varlesh]

@uvulpos Battery updated on master branch

[mcnesium]

Looks like class="ColorScheme-PositiveText" is now the default in all the battery icons. As far as I understood, this is the KDE-way of doing things. However, it breaks monochrome designs. For the state-ok icon, this has already been reverted to ColorScheme-Text to default to monochrome view. Is there a chance that this will happen to the battery icons, as well?

[varlesh]

@mcnesium Please see #2447.

• Monochrome (normal status) 30-100% without AC & 100% with AC. We specially doing this for not distract user, when you connect AC with full battery.
• Green (positive status) icons use when you charging from 0% - 90%
• Yellow (warning status) battery 20%
• Red (critical status) battery 0-10%

[varlesh]

AC disconnected:

AC connected:

[uvulpos]

Looks great! Good job! 😄

[ozls]

I don't understand why this version eventually won. It's beautiful, but I wholeheartedly agree with the input of @SmartFinn on bug #2447. My everyday situation is a laptop running on AC with a half empty battery that is not charging (for battery longevity reasons), and I find it very distracting to have the green accent in this case. On the other hand, in a situation where I'm running solely on battery, I would find it very useful to be reminded of its state constantly. So what gives ? Is there a practical reason behind this choice ? Can I do something ?

[intrnl]

Was wondering the same, I find the green battery to be distracting.

[95440b97d]

Can this be reopened? I agree with @ozls. The version of @SmartFinn makes absolutely more sense.

Keeping the battery not fully charged (on purpose) and plugged in nags you with an green accent color where attention is not needed (we are plugged in after all).

Whereas when the battery is discharging there's no nagging accent color (the color is monochrome). Here a nagging color is actually beneficial to remind the user of something he needs to pay attention to.

Using stock Gnome desktop.