Skip to content

Commit

Permalink
Added symlink for KDE Paartition Manager
Browse files Browse the repository at this point in the history
  • Loading branch information
morganist committed Aug 2, 2023
1 parent 3799d00 commit 52c2d58
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 0 deletions.
1 change: 1 addition & 0 deletions Papirus/16x16/apps/org.kde.partitionmanager.svg
1 change: 1 addition & 0 deletions Papirus/22x22/apps/org.kde.partitionmanager.svg
1 change: 1 addition & 0 deletions Papirus/24x24/apps/org.kde.partitionmanager.svg
1 change: 1 addition & 0 deletions Papirus/32x32/apps/org.kde.partitionmanager.svg
1 change: 1 addition & 0 deletions Papirus/48x48/apps/org.kde.partitionmanager.svg
1 change: 1 addition & 0 deletions Papirus/64x64/apps/org.kde.partitionmanager.svg

7 comments on commit 52c2d58

@SmartFinn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganist seems this symlink is useless. I can't find any package with the icon name Also, the app is not available as Flatpak. org.kde.partitionmanager.desktop is a desktop-file, but the icon name inside it is partitionmanager.

@morganist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmartFinn
I think I was kind of under impression then that if an app had a "flatpak.Name.with.dots", it would have an icon with the same name too... Didn't even bothered to check a desktop file, as far as I remember.

@morganist seems this symlink is useless.

However, there is a possibility that it would eventually be released as a flatpak in the future. KDE already uses this naming scheme for apps almost everywhere. So, I think it makes sense to keep such symlinks.

@SmartFinn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganist

I think it makes sense to keep such symlinks

I'm cleaning icons with RDNN (Reverse Domain Name Notation), and I don't want to make exceptions. Moreover, this approach is not correct.

@morganist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmartFinn I didn't know the icons that use RDNN for their names need to be cleaned. Is there so much of them unused?

@SmartFinn
Copy link
Member

@SmartFinn SmartFinn commented on 52c2d58 Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganist I have not finished yet, but now there is about 534 files / 6 = 89 unused icons/symlinks.

@morganist
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SmartFinn OK, I agree with you. Cleanup is great, no doubt here. But I wonder where they came from.

@SmartFinn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganist most of them are icons/symlinks for Flatpak packages for dead or renamed apps. See https://github.com/search?q=org%3Aflathub+end-of-life+path%3Aflathub.json&type=code

Please sign in to comment.