Fix some explosion damage not scaling with difficulty #8767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Misspelled your name ;) |
|
We should fix this in a general case to avoid issue with the new DamageOrigin API for custom origin |
Ok, that's what this PR does then. It checks if the field scalesWithDifficulty has been set, and if it has, overrides the check in EntityDamageSource. |
kennytv
approved these changes
Jan 10, 2023
471f24e to
ab04ff8
Compare
ab04ff8 to
e4e2ad2
Compare
maestro-denery
pushed a commit
to maestro-denery/Paper
that referenced
this pull request
Feb 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MC-258535
Fixes #8735
If we wanted to restrict the fix to those specific cases, I could add the override to
IndirectEntityDamageSourcewhich is the onlyEntityDamageSourcetype which has thesetScalesWithDifficulty()method called.