Github Actions CI Changes #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash these commits into a sensible commit history! I suspect a lot of the churn in this will be due to debugging history, which doesn't need to go into the final PR. |
076e6dd to
15738c8
Compare
|
All jobs are now on IRIS runners, but make_boot and test jobs require more attention:
The /scripts directory has been deleted, and an NFS mount at /opt/arc-panda on cs05r-sc-cloud-30 (rw for DCS group) is used instead of the S3 bucket. An adjusted dev-container is used as the runner's base image, a PR of which will be opened on the rootfs repository. |
|
A work-around for the 4hr test job is now in place
Overall duration of the matrix of test jobs is < 1hr; thus, no longer the limiting job. Overall duration of complete workflow is ~1hr. |
b139cfd to
ecc152a
Compare
Current CI jobs run similar blocks of code to checkout repos, install rclone and go, and mount the S3 bucket. This composite action YAML file will be called for instead.
External call to code.yml make_boot job
Make Boot and Test jobs require more attention. Make Boot currently hangs on completion, requiring a timeout and zip file check to successfully end job. Running tests on IRIS takes 3.5X as long. Running all jobs on IRIS with NFS mount, and removing jobs/scripts related to S3 or rclone Make Boot and Test jobs require more attention. Make Boot currently hangs on completion, requiring a timeout and zip file check to successfully end job. Running tests on IRIS seem to take 3.5X as long.
ecc152a to
c8e5642
Compare
dfc3ddc to
610fad6
Compare
610fad6 to
c1a750e
Compare
tomtrafford
previously approved these changes
Oct 9, 2024
coretl
previously approved these changes
Oct 14, 2024
coretl
previously approved these changes
Dec 9, 2024
coretl
approved these changes
Dec 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI workflow jobs now spread out into reusable workflows. Some repetitive steps (i.e., checkouts, rclone installations, S3 mounting, and registry login) moved to a composite actions. S3 mounting and registry login removed from actions, however, due to secrets becoming visible as inputs.
PR opened as draft until IRIS runners are available for CI jobs.