Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup]: Remove useMonaco hook #50

Merged
merged 4 commits into from
Apr 14, 2022
Merged

[Cleanup]: Remove useMonaco hook #50

merged 4 commits into from
Apr 14, 2022

Conversation

blindaa121
Copy link
Collaborator

@blindaa121 blindaa121 commented Apr 14, 2022

Description

  • Remove useMonaco() hook and revert to original import of Monaco type. CORS issue was caused by empty string values being passed into the editor. Issue resolved in [Bug Fix]: CORS Issue - Monaco editor #48
  • Add --openapi-required variable to style required schema fields

Motivation and Context

Using the useMonaco() hook alongside with Editor caused a duplicate module warning in the browser console.
Screen Shot 2022-04-14 at 11 38 35 AM

How Has This Been Tested?

Screenshots (if appropriate)

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@github-actions
Copy link

Size Change: -353 B (0%)

Total Size: 2.36 MB

Filename Size Change
demo/build/assets/css/styles.********.css 85.1 kB +43 B (0%)
demo/build/assets/js/4685.********.js 1.1 MB -227 B (0%)
demo/build/assets/js/4c5e977b.********.js 36.7 kB -169 B (0%)
ℹ️ View Unchanged
Filename Size
demo/.docusaurus/globalData.json 8.72 kB
demo/build/assets/js/066d920b.********.js 6.82 kB
demo/build/assets/js/0de0d9d3.********.js 11.4 kB
demo/build/assets/js/0e384e19.********.js 2.39 kB
demo/build/assets/js/0f5373df.********.js 9.78 kB
demo/build/assets/js/11cd04f0.********.js 15.8 kB
demo/build/assets/js/17896441.********.js 1.55 kB
demo/build/assets/js/18927b64.********.js 20 kB
demo/build/assets/js/18c41134.********.js 14.7 kB
demo/build/assets/js/1be78505.********.js 10.8 kB
demo/build/assets/js/1e4232ab.********.js 3.45 kB
demo/build/assets/js/1f391b9e.********.js 2.6 kB
demo/build/assets/js/1f41b3da.********.js 11.2 kB
demo/build/assets/js/2695.********.js 1.02 kB
demo/build/assets/js/2c9e856c.********.js 11.7 kB
demo/build/assets/js/3372.********.js 11.5 kB
demo/build/assets/js/393be207.********.js 921 B
demo/build/assets/js/42c7b392.********.js 17.8 kB
demo/build/assets/js/46a8ec8c.********.js 20.4 kB
demo/build/assets/js/477c195c.********.js 4.71 kB
demo/build/assets/js/4a47cb6d.********.js 1.34 kB
demo/build/assets/js/4c9d5d90.********.js 19.5 kB
demo/build/assets/js/4e8c00d7.********.js 9.79 kB
demo/build/assets/js/533a09ca.********.js 2.8 kB
demo/build/assets/js/5456.********.js 10 kB
demo/build/assets/js/5c2e4ff8.********.js 17 kB
demo/build/assets/js/5c868d36.********.js 3.52 kB
demo/build/assets/js/6ab70d68.********.js 10.2 kB
demo/build/assets/js/6d9cbd66.********.js 20.6 kB
demo/build/assets/js/71d92ba4.********.js 4.32 kB
demo/build/assets/js/7608cde2.********.js 1.31 kB
demo/build/assets/js/8084356f.********.js 10.9 kB
demo/build/assets/js/822bd8ab.********.js 3.19 kB
demo/build/assets/js/846aa161.********.js 17.6 kB
demo/build/assets/js/888b62d9.********.js 1.48 kB
demo/build/assets/js/8dd270d8.********.js 29.4 kB
demo/build/assets/js/935f2afb.********.js 3.54 kB
demo/build/assets/js/9719473f.********.js 1.24 kB
demo/build/assets/js/9e4087bc.********.js 1.61 kB
demo/build/assets/js/a9d8a64b.********.js 2.44 kB
demo/build/assets/js/b0e6d8b9.********.js 2.32 kB
demo/build/assets/js/b2f554cd.********.js 121 B
demo/build/assets/js/bb0d0959.********.js 2.12 kB
demo/build/assets/js/bd766368.********.js 9.49 kB
demo/build/assets/js/c3d13055.********.js 8.63 kB
demo/build/assets/js/c4f5d8e4.********.js 72.3 kB
demo/build/assets/js/ce11f325.********.js 10.9 kB
demo/build/assets/js/common.********.js 125 kB
demo/build/assets/js/d03381af.********.js 22.2 kB
demo/build/assets/js/da717792.********.js 16.4 kB
demo/build/assets/js/dc10a35a.********.js 16.5 kB
demo/build/assets/js/dde745ce.********.js 15.2 kB
demo/build/assets/js/dff1c289.********.js 4.2 kB
demo/build/assets/js/e1362e6d.********.js 1.37 kB
demo/build/assets/js/e44a2883.********.js 5.45 kB
demo/build/assets/js/f55d3e7a.********.js 3.01 kB
demo/build/assets/js/main.********.js 390 kB
demo/build/assets/js/runtime~main.********.js 6.35 kB
demo/build/index.html 72.6 kB

compressed-size-action

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit c5e794f):

https://docusaurus-openapi-36b86--pr50-lwyqqi5g.web.app

(expires Sat, 14 May 2022 21:06:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@blindaa121 blindaa121 self-assigned this Apr 14, 2022
@blindaa121 blindaa121 requested review from csestito and sserrata April 14, 2022 21:10
Copy link
Member

@sserrata sserrata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@blindaa121 blindaa121 merged commit 529652d into panw-main Apr 14, 2022
@blindaa121 blindaa121 deleted the editor-cleanup branch April 14, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants