Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Fixup for hyphens/dashes with extra bytes #387

Merged

Conversation

joshuawillis
Copy link
Contributor

The extra bytes on the dashes was causing problems running the ansible-playbook for me...

SyntaxError: Non-ASCII character '\xe2' in file /var/folders/9f/5hk0x6ws7tlb7bs1cgnxgkh40000gn/T/ansible_panos_ipsec_tunnel_payload_ODxp9L/__main__.py on line 83, but no encoding declared; see http://python.org/dev/peps/pep-0263/ for details1
I'm removing them and standardizing them.

I checked which lines had extra bytes:

84 '             \xe2\x80\x93 Inbound SPI in hex (manual-key).\n'
87 '             \xe2\x80\x93 Tunnel peer IP address (manual-key).\n'
90 '             \xe2\x80\x93 Exact IP address if interface has multiple IP addresses (manual-key).\n'
93 '             \xe2\x80\x93 Floating IP address in HA Active-Active configuration (manual-key).\n'
96 '            \xe2\x80\x93 Protocol for traffic through the tunnel (manual-key).\n'
104 '             \xe2\x80\x93 Authentication key (manual-key).\n'
114 '             \xe2\x80\x93 GlobalProtect portal address (global-protect-satellite).\n'
117 '             \xe2\x80\x93 Prefer to register portal in IPv6 (8.0+) (global-protect-satellite).\n'
122 '            \xe2\x80\x93 Interface to communicate with portal (global-protect-satellite).\n'
125 '            \xe2\x80\x93 Exact IPv4 IP address if interface has multiple IP addresses (global-protect-satellite).\n'
128 '             \xe2\x80\x93 Exact IPv6 IP address if interface has multiple IP addresses (8.0+) (global-protect-satellite).\n'
131 '            \xe2\x80\x93 Floating IPv4 IP address in HA Active-Active configuration (7.0+) (global-protect-satellite).\n'
134 '            \xe2\x80\x93 Floating IPv6 IP address in HA Active-Active configuration (8.0+) (global-protect-satellite).\n'
137 '            \xe2\x80\x93 Enable publishing of connected and static routes (global-protect-satellite).\n'
149 '            \xe2\x80\x93 Profile for authenticating GlobalProtect gateway certificates (global-protect-satellite).\n'
157 '            \xe2\x80\x93 Copy IPv6 flow label for 6in6 tunnel from inner packet to IPSec packet (not recommended) (7.0+).\n' ```

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for this!

@shinmog shinmog merged commit e013fb9 into PaloAltoNetworks:develop Jun 10, 2019
shinmog added a commit that referenced this pull request Jun 11, 2019
* Declare module encoding

* adding function to turn pandevice objects to dicts

* adding panos_zone_facts

* Module ipv4 proxyid for ipsec tunnel (#380)

* Added module panos_ipsec_ipv4_proxyid

* Fixed test build problem

* Applied changes requested by @shinmog

* Fix build problem

* Additionally requested changes by @shinmog

* adding panos_virtual_router_facts (#383)

* fixing RETURNS section

* adding panos_l3_subinterface (#384)

* Correcting example documentation

* adding panos_l2_subinterface (#385)

* Policy facts details (#376)

* Updated documentation for security_rule_facts

* Documentation re-built

* Get full details when querying all rules using 'all_details: yes' argument

* Small fixes to panos_security_rule_facts

* Bug fixes panos_security_rule_facts.py

* Fixup for hyphens/dashes with extra bytes (#387)

* Adding param: 'vsys_shared' (#388)

* adding support for log forwarding profiles (#391)

* adding support for log forwarding profiles

* fixing code style issue

* adding support for email profiles (#389)

* adding support for snmp profiles (#392)

* adding support for syslog profiles (#393)

* adding support for syslog profiles

* fixing code style issue

* adding support for http profiles (#390)

* correcting arg to vsys_shared

* adding panos_type_cmd (#394)

* Updating to 2.2.0 (#395)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants