Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test file for edit profile page #2320

Closed
wants to merge 0 commits into from
Closed

Added test file for edit profile page #2320

wants to merge 0 commits into from

Conversation

Insiyaya
Copy link
Contributor

Added test file for edit profile page with required testing classes and widgets

What kind of change does this PR introduce?

Issue Number: #1522

Fixes #1522

Did you add tests for your changes?

Yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Test case file for edit profile page

Does this PR introduce a breaking change? No

Other information

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@literalEval
Copy link
Member

@Insiyaya please format the code properly before opening PRs. Thanks.

@Cyclotron17
Copy link

Hey , can you please assign this issue to me.

@Insiyaya
Copy link
Contributor Author

@Insiyaya please format the code properly before opening PRs. Thanks.

Hey can you brief what changes i have to make in the code..It will be easy then

@literalEval
Copy link
Member

@Insiyaya you need to run "dart format --set-exit-if-changed ." before commiting. This is mentioned in Contribuing.md

@Insiyaya
Copy link
Contributor Author

@Insiyaya you need to run "dart format --set-exit-if-changed ." before commiting. This is mentioned in Contribuing.md

Okay

@Insiyaya
Copy link
Contributor Author

I have formatted the code and pushed it

literalEval
literalEval approved these changes Jan 14, 2024
Copy link
Member

@literalEval literalEval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the test is failing. Fix it.

@Insiyaya Insiyaya requested a review from literalEval January 15, 2024 07:00
@Dante291
Copy link
Contributor

Dante291 commented Jan 15, 2024

@Insiyaya why new test file for edit_profile_page? There's already a test file for this page here, Just move the file to right folder.

Currently the coverage for this file is 95% you just have to add more tests so that coverage get to 100%, you can check the current coverage for this file here. Check for lines which are uncovered and write test for those.

@Insiyaya
Copy link
Contributor Author

@Insiyaya why new test file for edit_profile_page? There's already a test file for this page here, Just move the file to right folder.

Currently the coverage for this file is 95% you just have to add more tests so that coverage get to 100%, you can check the current coverage for this file here. Check for lines which are uncovered and write test for those.

Thanks to clear the issue, i will add more test cases in this file

@Insiyaya
Copy link
Contributor Author

Mentors Please Review my recent PR

@Insiyaya
Copy link
Contributor Author

hey mentors, can you explain me or help me figure out what is the issue in the file? it is failing checking codebase test

@palisadoes
Copy link
Contributor

Please read the error, it is explained there

@Insiyaya
Copy link
Contributor Author

Please read the error, it is explained there
Yes i checked it and this is the error...but i have not changed anything in these files given below..so i am not understanding basically what to do..plwase help me figure that out..thanks :)
[Ignore directive for custom lint rule found. Please remove them and add valid documentation.

File name: lib/models/organization/org_info.g.dart

File name: lib/views/pre_auth_screens/waiting_to_join_private_org.dart...]

@Azad99-9
Copy link
Contributor

@Insiyaya even though you didn't change any related code, it's a good practice to remove ignore directives and add docs to specified files. Please add docs to get your PR reviewed.

@Dante291
Copy link
Contributor

Also why are you removing profile_page_test.dart file?

@Insiyaya
Copy link
Contributor Author

Also why are you removing profile_page_test.dart file?

it was previously added by me cuz of some misconceptions

@Insiyaya Insiyaya closed this Jan 18, 2024
@palisadoes
Copy link
Contributor

@Insiyaya

We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:

  1. We start looking for people to review PRs when you submit them.
  2. We often contact them and link to the PR. If the PR is closed the whole effort is wasted.
  3. The historical thread of reviewer comments is broken when the work is spread across multiple PRs. The quality of our code is affected negatively.

Please be considerate of our volunteers' limited time and our desire to improve our code base.

This policy is stated as a pinned post in all our Talawa repositories.

We value all contributions to the repository, but the frequency of this type of activity has forced our hand.

We will enforce this policy the next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test edit_profile_page.dart
6 participants