-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test file for edit profile page #2320
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@Insiyaya please format the code properly before opening PRs. Thanks. |
Hey , can you please assign this issue to me. |
Hey can you brief what changes i have to make in the code..It will be easy then |
@Insiyaya you need to run "dart format --set-exit-if-changed ." before commiting. This is mentioned in Contribuing.md |
Okay |
I have formatted the code and pushed it |
test/views/after_auth_screens/profile/edit_profile_page_test.dart
Outdated
Show resolved
Hide resolved
test/views/after_auth_screens/profile/edit_profile_page_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the test is failing. Fix it.
@Insiyaya why new test file for edit_profile_page? There's already a test file for this page here, Just move the file to right folder. Currently the coverage for this file is 95% you just have to add more tests so that coverage get to 100%, you can check the current coverage for this file here. Check for lines which are uncovered and write test for those. |
Thanks to clear the issue, i will add more test cases in this file |
Mentors Please Review my recent PR |
hey mentors, can you explain me or help me figure out what is the issue in the file? it is failing checking codebase test |
Please read the error, it is explained there |
|
@Insiyaya even though you didn't change any related code, it's a good practice to remove ignore directives and add docs to specified files. Please add docs to get your PR reviewed. |
Also why are you removing profile_page_test.dart file? |
it was previously added by me cuz of some misconceptions |
We have a policy of unassigning contributors who close PRs without getting validation from our reviewer team. This is because:
Please be considerate of our volunteers' limited time and our desire to improve our code base. This policy is stated as a pinned post in all our Talawa repositories. We value all contributions to the repository, but the frequency of this type of activity has forced our hand. We will enforce this policy the next time. |
Added test file for edit profile page with required testing classes and widgets
What kind of change does this PR introduce?
Issue Number: #1522
Fixes #1522
Did you add tests for your changes?
YesSnapshots/Videos:
If relevant, did you update the documentation?
Summary
Test case file for edit profile pageDoes this PR introduce a breaking change? No
Other information
Have you read the contributing guide?
Yes