Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed app setting button #2202

Merged
merged 1 commit into from
Dec 3, 2023
Merged

removed app setting button #2202

merged 1 commit into from
Dec 3, 2023

Conversation

ShubhamTiwari55
Copy link
Contributor

What kind of change does this PR introduce?

Removed the App setting button as mentioned in issue #2197

Issue Number:

Fixes #2197

Did you add tests for your changes?

No

Snapshots/Videos:
Snapshot

If relevant, did you update the documentation?

No

Summary

Removed the App setting button as it was of no use

Does this PR introduce a breaking change?

No

Copy link

github-actions bot commented Dec 3, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (004b014) 79.92% compared to head (c550066) 79.94%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2202      +/-   ##
===========================================
+ Coverage    79.92%   79.94%   +0.02%     
===========================================
  Files          149      149              
  Lines         6973     6971       -2     
===========================================
  Hits          5573     5573              
+ Misses        1400     1398       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 8897d02 into PalisadoesFoundation:develop Dec 3, 2023
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Settings: App Setting option doesn't work and should be removed
2 participants