-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the App setting button #2201
Removed the App setting button #2201
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no need to update these files for this PR. Please remove them. Make sure you are running the correct flutter version for the repo.
android/app/build.gradle
pubspec.lock
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2201 +/- ##
===========================================
+ Coverage 79.92% 79.94% +0.02%
===========================================
Files 149 149
Lines 6973 6971 -2
===========================================
Hits 5573 5573
+ Misses 1400 1398 -2 ☔ View full report in Codecov by Sentry. |
I have removed all the changes done to the above mentioned files. Sorry for the inconvenience. Kindly review the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You still have the files in the PR. Remove them.
- You need to get our code coverage up to 100% for the edited file. It is currently under 1%
Closing.
Please be more careful. |
What kind of change does this PR introduce?
Removed the App setting button as mentioned in issue #2197
Issue Number:
Fixes #2197
Did you add tests for your changes?
No
Snapshots/Videos:
![Snapshot](https://private-user-images.githubusercontent.com/125534462/287463157-296cbed6-79be-4553-b25a-529a033694ea.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2Njc4MDQsIm5iZiI6MTczOTY2NzUwNCwicGF0aCI6Ii8xMjU1MzQ0NjIvMjg3NDYzMTU3LTI5NmNiZWQ2LTc5YmUtNDU1My1iMjVhLTUyOWEwMzM2OTRlYS5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMDU4MjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04Zjk3NDE2ZGUyNTdiNTRhNDVmMzgwYjFiYTY4YzFiNGRlMjMxNDFjZjI4MWYyOGU1YWIwODNhNjMyNzQyZGQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.CAQt5aouC6CFUnX4XfC3VYNVmRQ2EPUtw9E1RPJc1Ag)
If relevant, did you update the documentation?
No
Summary
Removed the App setting button as it was of no use
Does this PR introduce a breaking change?
No