Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the App setting button #2201

Closed
wants to merge 5 commits into from
Closed

Removed the App setting button #2201

wants to merge 5 commits into from

Conversation

ShubhamTiwari55
Copy link
Contributor

@ShubhamTiwari55 ShubhamTiwari55 commented Dec 2, 2023

What kind of change does this PR introduce?

Removed the App setting button as mentioned in issue #2197

Issue Number:

Fixes #2197

Did you add tests for your changes?

No

Snapshots/Videos:
Snapshot

If relevant, did you update the documentation?

No

Summary

Removed the App setting button as it was of no use

Does this PR introduce a breaking change?

No

Copy link

github-actions bot commented Dec 2, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no need to update these files for this PR. Please remove them. Make sure you are running the correct flutter version for the repo.

  1. android/app/build.gradle
  2. pubspec.lock

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (004b014) 79.92% compared to head (49eb6d1) 79.94%.

❗ Current head 49eb6d1 differs from pull request most recent head 12259a6. Consider uploading reports for the commit 12259a6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2201      +/-   ##
===========================================
+ Coverage    79.92%   79.94%   +0.02%     
===========================================
  Files          149      149              
  Lines         6973     6971       -2     
===========================================
  Hits          5573     5573              
+ Misses        1400     1398       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShubhamTiwari55
Copy link
Contributor Author

There should be no need to update these files for this PR. Please remove them. Make sure you are running the correct flutter version for the repo.

  1. android/app/build.gradle
  2. pubspec.lock

I have removed all the changes done to the above mentioned files. Sorry for the inconvenience. Kindly review the changes

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You still have the files in the PR. Remove them.
  2. You need to get our code coverage up to 100% for the edited file. It is currently under 1%

@palisadoes
Copy link
Contributor

Closing.

  1. You took my advice of removing the files literally and not in the context. They should be removed from the PR not the repo.
  2. Resubmit the PR when
    1. You have edited the necessary file(s) to complete the issue
    2. You have created tests to cover 100% of the lines of the files you have edited to complete the issue.

Please be more careful.

@palisadoes palisadoes closed this Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Settings: App Setting option doesn't work and should be removed
2 participants