Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a comment to a news feed entry fails #2190

Closed
palisadoes opened this issue Dec 1, 2023 · 8 comments · Fixed by #2248
Closed

Adding a comment to a news feed entry fails #2190

palisadoes opened this issue Dec 1, 2023 · 8 comments · Fixed by #2248
Assignees
@imshivam-gupta
Labels
bug Something isn't working

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 1, 2023 •
edited by Cioppolo14
Loading

Describe the bug

A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Expected behavior

  • Comment created

Actual behavior

  • No comment created

Screenshots

  • N/A

Additional details

  • You must get the test code coverage up to 100% for any edited files. No functionality must be removed to achieve this goal.
@palisadoes palisadoes added the bug Something isn't working label Dec 1, 2023
@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Dec 1, 2023
@imshivam-gupta
Copy link
Contributor

@palisadoes I would like to work on this issue.. can you please assign it to me?

@Ayush0Chaudhary
Copy link
Contributor

Please solve other issues first.

@imshivam-gupta
Copy link
Contributor

imshivam-gupta commented Dec 5, 2023 •
edited
Loading

@Ayush0Chaudhary @noman2002 Currently I have no issue assigned. I would like to work upon this issue.. Can you please assign it to me?

@imshivam-gupta
Copy link
Contributor

@palisadoes @noman2002, I've ensured that comments are being successfully added to the database. However, they aren't currently visible because the GraphQL client is using the query commentsByPost(id:$id), which is not present in the talwa-api.

At this point, I have a couple of proposed solutions. Firstly, I can update the code to ensure that comments are added to the database. Then, when the talwa-api executes a GraphQL query, the comments will become visible.

Alternatively, I can create an issue on talwa-api and address it myself. I've identified what needs to be added to talwa-api, and I can work on this issue sequentially to ensure a comprehensive resolution.

Please provide guidance on which approach to take.

image

@noman2002 noman2002 removed the unapproved Unapproved, needs to be triaged label Dec 6, 2023
@imshivam-gupta
Copy link
Contributor

@noman2002 @palisadoes Can you please confirm which way to proceed?

@noman2002
Copy link
Member

noman2002 commented Dec 6, 2023 •
edited
Loading

@imshivam-gupta Create an issue on the api. and link this this issue over their.

@imshivam-gupta imshivam-gupta mentioned this issue Dec 6, 2023
Closed
@imshivam-gupta imshivam-gupta mentioned this issue Dec 14, 2023
Merged
@github-actions GitHub Actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 17, 2023
@imshivam-gupta
Copy link
Contributor

I have already created a PR for this issue which is yet to be approved.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imshivam-gupta imshivam-gupta

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

News feed comment fix imshivam-gupta/talawa
4 participants
@palisadoes @noman2002 @imshivam-gupta @Ayush0Chaudhary