Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commentsByPost graphql query not present #1460

Closed
imshivam-gupta opened this issue Dec 6, 2023 · 3 comments
Closed

commentsByPost graphql query not present #1460

imshivam-gupta opened this issue Dec 6, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@imshivam-gupta
Copy link

Describe the bug

  • Query called commentsByPost is not present in graphql queries which is expected from the talwa fetch comments service.

To Reproduce
Steps to reproduce the behavior:

This issue is linked to Issue 2190

Expected behavior
We need to have graphql query to fetch data as expected

Screenshots
image

@imshivam-gupta imshivam-gupta added the bug Something isn't working label Dec 6, 2023
@imshivam-gupta
Copy link
Author

@noman2002 Can you please assign this issue to me

Copy link

github-actions bot commented Dec 6, 2023

Congratulations on making your first Issue! 🎊 If you haven't already, check out our Contributing Guidelines and Issue Reporting Guidelines to ensure that you are following our guidelines for contributing and making issues.

@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Dec 6, 2023
@noman2002 noman2002 removed the unapproved Unapproved for Pull Request label Dec 6, 2023
@imshivam-gupta
Copy link
Author

I have checked the existing GraphQL schema and confirmed that it already satisfies the requirements for commentsByPost. There was no need for a separate query. I opened this issue initially to create APIs for the frontend, but I now realize that updating the frontend queries suffices. Thanks @xoldyckk for providing this insight; it was overlooked by me earlier. I also noticed that the Talawa-API has many redundant queries, for which I will definitely create issues in the future. This way, we can maintain sustainable code without the need for additional queries. @palisadoes I am closing this pull request and will chnage the frontend query directly to fetch the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants