Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for src/resolvers/Mutations/addUserImage #931

Merged
merged 3 commits into from
Jan 29, 2023
Merged

Tests for src/resolvers/Mutations/addUserImage #931

merged 3 commits into from
Jan 29, 2023

Conversation

kb-0311
Copy link
Contributor

@kb-0311 kb-0311 commented Jan 27, 2023

What kind of change does this PR introduce?

Issue Number:

Fixes #909

Did you add tests for your changes?

Yes
Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Yes

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #931 (ee23450) into develop (3204c73) will increase coverage by 5.35%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #931      +/-   ##
===========================================
+ Coverage    82.79%   88.15%   +5.35%     
===========================================
  Files          168      168              
  Lines        10087    10097      +10     
  Branches       882      939      +57     
===========================================
+ Hits          8352     8901     +549     
+ Misses        1733     1196     -537     
+ Partials         2        0       -2     
Impacted Files Coverage Δ
src/utilities/uploadImage.ts 100.00% <100.00%> (+83.63%) ⬆️
src/resolvers/Mutation/createEvent.ts 88.80% <0.00%> (+0.25%) ⬆️
src/resolvers/Mutation/joinPublicOrganization.ts 100.00% <0.00%> (+7.07%) ⬆️
src/resolvers/Mutation/createDirectChat.ts 100.00% <0.00%> (+7.22%) ⬆️
src/resolvers/Mutation/refreshToken.ts 100.00% <0.00%> (+11.76%) ⬆️
src/resolvers/Mutation/createPost.ts 100.00% <0.00%> (+14.70%) ⬆️
src/resolvers/Mutation/createOrganization.ts 100.00% <0.00%> (+14.70%) ⬆️
src/resolvers/Mutation/addOrganizationImage.ts 100.00% <0.00%> (+18.30%) ⬆️
...rc/resolvers/Mutation/updatePluginInstalledOrgs.ts 100.00% <0.00%> (+25.45%) ⬆️
src/resolvers/Mutation/addUserImage.ts 100.00% <0.00%> (+27.45%) ⬆️
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to get the coverage of uploadImage.ts to 100% .

@noman2002
Copy link
Member

@kb-0311 Good work, its at 87.27% now. Get it to 100%

@kb-0311
Copy link
Contributor Author

kb-0311 commented Jan 29, 2023

@noman2002
Yep Thanks.
Now, uploadImage has 100% test coverage.
I will submit another PR for deleteImage by tomorrow.
This PR also closes #886

@palisadoes palisadoes merged commit 078cfb4 into PalisadoesFoundation:develop Jan 29, 2023
@kb-0311 kb-0311 mentioned this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: src/lib/resolvers/Mutation/addUserImage.ts
4 participants