-
-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor onPluginUpdate, added tests for it #2114
refactor onPluginUpdate, added tests for it #2114
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2114 +/- ##
===========================================
+ Coverage 96.17% 96.24% +0.07%
===========================================
Files 333 333
Lines 22536 22536
Branches 1949 1987 +38
===========================================
+ Hits 21673 21690 +17
+ Misses 854 839 -15
+ Partials 9 7 -2 ☔ View full report in Codecov by Sentry. |
@NamitBhutani You should have a specific issue to link to, not the parent issue. Can you please link that? |
Done! Sorry for the oversight. |
@DMills27 @SiddheshKukade Can you review this PR? |
What kind of change does this PR introduce?
refactor, tests
Issue Number:
Fixes #1923
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes