Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor onPluginUpdate, added tests for it #2114

Merged

Conversation

NamitBhutani
Copy link
Contributor

@NamitBhutani NamitBhutani commented Mar 28, 2024

What kind of change does this PR introduce?
refactor, tests

Issue Number:

Fixes #1923

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (36b3f5d) to head (85b64ab).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2114      +/-   ##
===========================================
+ Coverage    96.17%   96.24%   +0.07%     
===========================================
  Files          333      333              
  Lines        22536    22536              
  Branches      1949     1987      +38     
===========================================
+ Hits         21673    21690      +17     
+ Misses         854      839      -15     
+ Partials         9        7       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cioppolo14
Copy link
Contributor

@NamitBhutani You should have a specific issue to link to, not the parent issue. Can you please link that?

@NamitBhutani
Copy link
Contributor Author

@NamitBhutani You should have a specific issue to link to, not the parent issue. Can you please link that?

Done! Sorry for the oversight.

@Cioppolo14
Copy link
Contributor

@DMills27 @SiddheshKukade Can you review this PR?

@palisadoes palisadoes merged commit 876beae into PalisadoesFoundation:develop Mar 28, 2024
11 checks passed
@palisadoes palisadoes linked an issue Mar 28, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Test: src/resolvers/Subscription/onPluginUpdate.ts
3 participants