Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for user family members #1810

Merged

Conversation

AdityaRaimec22
Copy link
Contributor

@AdityaRaimec22 AdityaRaimec22 commented Feb 7, 2024

What kind of change does this PR introduce?
Add Support for User Family Members

Issue Number:

Fixes #1584

Did you add tests for your changes?
Yes

Snapshots/Videos:

If relevant, did you update the documentation?
Not relevant

Summary

Does this PR introduce a breaking change?
No

Other information
Some tests are failing and I am currently addressing them, and I have raised a pull request because the assigned issue has been pending for a significant period.

Have you read the contributing guide?
Yes

Copy link

github-actions bot commented Feb 7, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@AdityaRaimec22 AdityaRaimec22 changed the title added all the code Added support for user family members Feb 7, 2024
@AdityaRaimec22
Copy link
Contributor Author

AdityaRaimec22 commented Feb 7, 2024

@palisadoes The linting errors are failing for no reason and they are failing for all the files present in the codebase I noticed this behaviour in PR #1807 also. This can be solved by running npm run format:fix locally but then it will result in linting test failure for all those which I haven't changed but changed by prettier and will also result in total files changed count exeeding 400. There is no issue in my PR.

@Cioppolo14
Copy link
Contributor

@AdityaRaimec22 There are some other tests failed/skipped, can you fix them or address them in a comment as well?

@AdityaRaimec22
Copy link
Contributor Author

AdityaRaimec22 commented Feb 7, 2024

@Cioppolo14 The two tests are skipped because linting tests failed. Once they are passed then they will run.

@Cioppolo14
Copy link
Contributor

@AdityaRaimec22 Okay, let me know when your linting has passed and you think its ready for reviewers. Thank you!

@palisadoes
Copy link
Contributor

Please do a minor commit. I made a change that hopefully should fix the linting GitHub action.

@AdityaRaimec22
Copy link
Contributor Author

AdityaRaimec22 commented Feb 8, 2024

Please do a minor commit. I made a change that hopefully should fix the linting GitHub action.

@palisadoes It didn't work. The files in this PR are already linted by pre commit hook.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (bb54f66) 98.14% compared to head (9e1ca77) 97.91%.
Report is 6 commits behind head on develop.

Files Patch % Lines
src/resolvers/Mutation/removeUserFromUserFamily.ts 82.17% 22 Missing and 1 partial ⚠️
src/resolvers/Mutation/addUserToUserFamily.ts 78.04% 18 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1810      +/-   ##
===========================================
- Coverage    98.14%   97.91%   -0.24%     
===========================================
  Files          226      234       +8     
  Lines        13685    14125     +440     
  Branches      1144     1175      +31     
===========================================
+ Hits         13431    13830     +399     
- Misses         222      262      +40     
- Partials        32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AdityaRaimec22
Copy link
Contributor Author

@palisadoes Everything is fine now. You can merge this PR.

@palisadoes palisadoes merged commit fa10711 into PalisadoesFoundation:develop Feb 8, 2024
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants