-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for user family members #1810
Added support for user family members #1810
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@palisadoes The linting errors are failing for no reason and they are failing for all the files present in the codebase I noticed this behaviour in PR #1807 also. This can be solved by running |
@AdityaRaimec22 There are some other tests failed/skipped, can you fix them or address them in a comment as well? |
@Cioppolo14 The two tests are skipped because linting tests failed. Once they are passed then they will run. |
@AdityaRaimec22 Okay, let me know when your linting has passed and you think its ready for reviewers. Thank you! |
Please do a minor commit. I made a change that hopefully should fix the linting GitHub action. |
…into newUserFamily
@palisadoes It didn't work. The files in this PR are already linted by pre commit hook. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1810 +/- ##
===========================================
- Coverage 98.14% 97.91% -0.24%
===========================================
Files 226 234 +8
Lines 13685 14125 +440
Branches 1144 1175 +31
===========================================
+ Hits 13431 13830 +399
- Misses 222 262 +40
- Partials 32 33 +1 ☔ View full report in Codecov by Sentry. |
@palisadoes Everything is fine now. You can merge this PR. |
fa10711
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Add Support for User Family Members
Issue Number:
Fixes #1584
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Not relevant
Summary
Does this PR introduce a breaking change?
No
Other information
Some tests are failing and I am currently addressing them, and I have raised a pull request because the assigned issue has been pending for a significant period.
Have you read the contributing guide?
Yes