-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standarized file uploads #1773
standarized file uploads #1773
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@manishjha-04 Please set the image size in MB and update the installation.md file for the new parameters. |
@Cioppolo14 done!..please review! |
@manishjha-04 Please fix the linting/formatting test errors. |
hey @Cioppolo14 fixed the linting issue |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1773 +/- ##
===========================================
- Coverage 98.17% 97.83% -0.35%
===========================================
Files 184 227 +43
Lines 10767 13781 +3014
Branches 835 1151 +316
===========================================
+ Hits 10571 13483 +2912
- Misses 186 266 +80
- Partials 10 32 +22 ☔ View full report in Codecov by Sentry. |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing due to inactivity |
Hi @palisadoes , @Cioppolo14 , I hope you're doing well. The PR was closed without review. Could you kindly share why it was closed prematurely? I'm eager to learn and improve. |
My mistake. I was using my phone and was looking at the wrong screen in making the decision. Reopening |
Due to work commitments this will probably not be reviewed until the weekend |
Okay Sir , no issues! 😃 |
NOTE Read very carefully
This will help to reduce the number of future merge conflicts for your PR. |
@manishjha-04 Can you resolve the conflicting files? |
Sure would be resolving it soon! |
Pull Request: Standarizing file Uploads
Description
This pull request addresses the issue < #1715 >, which involves
Changes Made
.env.sample
.setup.ts
to prompt the user for image upload settings and update the.env
file accordingly.Video
Below is changes made in setup.ts file as asked for in the previous PR
20240131-2050-02.5856874.mp4