-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commented firebase notification code #1503
Conversation
…stallation and configuration instructions
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1503 +/- ##
===========================================
- Coverage 98.17% 97.45% -0.73%
===========================================
Files 184 214 +30
Lines 10767 12949 +2182
Branches 835 1042 +207
===========================================
+ Hits 10571 12620 +2049
- Misses 186 299 +113
- Partials 10 30 +20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aim is to remove all references to firebase in the code base not just for creating events therefore:
- References to firebase packages need to be removed from
package.json
- All references to firebase in the code base
Okay got it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also remove references here https://github.com/PalisadoesFoundation/talawa-api/blob/develop/.env.sample
Yup,working on it. |
Ig now, I have removed all the instances of Firebase from the codebase; please review. |
|
@Veer0x1 , we are also storing FCM token through mutation and asking for androidFirebaseOptions, iOSFirebaseOptions through Query. |
In my attempt to eliminate all Firebase references, I systematically removed them and deleted the Firebase package. After running all tests, I observed that all but two tests (which were failing before also )passed successfully. Consequently, I believe I have successfully eradicated all traces of Firebase from the codebase. |
281b865
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Commented the Firebase notification on creating an event, and also test corresponding to it. And also removed firebase-related installation and configuration instructions.
Issue Number:
Fixes #1500
Did you add tests for your changes?
NA
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes