Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented firebase notification code #1503

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

Veer0x1
Copy link
Contributor

@Veer0x1 Veer0x1 commented Dec 17, 2023

What kind of change does this PR introduce?
Commented the Firebase notification on creating an event, and also test corresponding to it. And also removed firebase-related installation and configuration instructions.

Issue Number:

Fixes #1500

Did you add tests for your changes?
NA

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?
Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (c0468a4) 98.17% compared to head (32e657d) 97.45%.
Report is 86 commits behind head on develop.

Files Patch % Lines
src/utilities/PII/decryption.ts 0.00% 17 Missing ⚠️
src/resolvers/Mutation/updateUserProfile.ts 70.90% 1 Missing and 15 partials ⚠️
src/resolvers/middleware/currentUserExists.ts 45.83% 13 Missing ⚠️
src/utilities/PII/encryption.ts 0.00% 13 Missing ⚠️
src/utilities/PII/isAuthorised.ts 0.00% 11 Missing ⚠️
...tilities/encodedVideoStorage/uploadEncodedVideo.ts 90.12% 8 Missing ⚠️
src/resolvers/Mutation/createPost.ts 86.95% 6 Missing ⚠️
src/resolvers/Mutation/removeAdvertisement.ts 92.85% 2 Missing ⚠️
...c/resolvers/Query/postsByOrganizationConnection.ts 33.33% 2 Missing ⚠️
src/resolvers/Subscription/onPluginUpdate.ts 0.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1503      +/-   ##
===========================================
- Coverage    98.17%   97.45%   -0.73%     
===========================================
  Files          184      214      +30     
  Lines        10767    12949    +2182     
  Branches       835     1042     +207     
===========================================
+ Hits         10571    12620    +2049     
- Misses         186      299     +113     
- Partials        10       30      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aim is to remove all references to firebase in the code base not just for creating events therefore:

  1. References to firebase packages need to be removed from package.json
  2. All references to firebase in the code base

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 17, 2023

Okay got it.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 17, 2023

Yup,working on it.

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 17, 2023

Ig now, I have removed all the instances of Firebase from the codebase; please review.

@palisadoes
Copy link
Contributor

  1. Are you removing all Firebase references or only those related to events? If not, what other Firebase references would be left?
  2. We will eventually need to remove all references.

@Abhisheksainii
Copy link

@Veer0x1 , we are also storing FCM token through mutation and asking for androidFirebaseOptions, iOSFirebaseOptions through Query.
Kindly check if these references to firebase has also been removed.

@Veer0x1
Copy link
Contributor Author

Veer0x1 commented Dec 18, 2023

  1. Are you removing all Firebase references or only those related to events? If not, what other Firebase references would be left?
  2. We will eventually need to remove all references.

In my attempt to eliminate all Firebase references, I systematically removed them and deleted the Firebase package. After running all tests, I observed that all but two tests (which were failing before also )passed successfully. Consequently, I believe I have successfully eradicated all traces of Firebase from the codebase.

@palisadoes palisadoes self-requested a review December 18, 2023 17:41
@palisadoes palisadoes merged commit 281b865 into PalisadoesFoundation:develop Dec 18, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of firebase messaging from Create Event
4 participants