Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First PR | added Mutation functions for Email Verification using OTP #1242

Closed

Conversation

KhushiTayal
Copy link

What kind of change does this PR introduce?

Mutation functions for email verification using otp , for signup.

Issue Number:

Improve registration validation #492 (talawa-admin)

Did you add tests for your changes?

Nope . Please help with that .

Snapshots/Videos:

Okay

If relevant, did you update the documentation?

Not relevant

Summary

Improving Registration through email otp verification

Does this PR introduce a breaking change?

No

Other information
No

Have you read the contributing guide?

Yes

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1242 (d372696) into develop (b7bf9b3) will increase coverage by 0.90%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1242      +/-   ##
===========================================
+ Coverage    98.61%   99.52%   +0.90%     
===========================================
  Files          176      177       +1     
  Lines        11055    10258     -797     
  Branches       836      765      -71     
===========================================
- Hits         10902    10209     -693     
+ Misses         153       48     -105     
- Partials         0        1       +1     

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Cioppolo14
Copy link
Contributor

There isn’t an issue assigned to you for this PR. Please follow the guidelines in our PR_GUIDELINES.md file. We have the procedures in place so that everyone has a fair chance of contributing. I will be closing this pull request. Please follow the procedures.

@Cioppolo14 Cioppolo14 closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants