Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthorized Post Creation Across Organizations #1959

Closed
krishna619 opened this issue Mar 7, 2024 · 11 comments
Closed

Unauthorized Post Creation Across Organizations #1959

krishna619 opened this issue Mar 7, 2024 · 11 comments
Assignees
Labels
bug Something isn't working feature request security Security fix

Comments

@krishna619
Copy link
Contributor

Describe the bug
I observed that changing the organizationId parameter allows a user to create a post in an organization to which they do not belong. This behavior poses a security risk as it allows unauthorized access to post creation across different organizations.

To Reproduce
Steps to reproduce the behavior:

  1. Intercept the createPost request.
  2. Change the value organizationId field to some other valid organization.
createpost_owatu8Yf.mp4

Screenshots
If applicable, add screenshots to help explain your problem.

Additional details
Add any other context or screenshots about the feature request here.

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship PalisadoesFoundation/talawa#359

@krishna619 krishna619 added the bug Something isn't working label Mar 7, 2024
@github-actions github-actions bot added feature request security Security fix unapproved Unapproved for Pull Request labels Mar 7, 2024
@krishna619
Copy link
Contributor Author

image

  1. I can remove any org even if I do not belong to that org.
  2. I can disable any plugin even if I do not belong to that org.

@takshakmudgal
Copy link
Contributor

I'd like to work on this issue.

@Huy1996 Huy1996 removed the unapproved Unapproved for Pull Request label Mar 8, 2024
@takshakmudgal
Copy link
Contributor

Been busy working on PalisadoesFoundation/talawa-admin#1676 will take up #1959 soon.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 24, 2024
@palisadoes
Copy link
Contributor

Unassigning no activity

@Manik2708
Copy link
Contributor

Can I work on this? @palisadoes @Cioppolo14

@dhanagopu dhanagopu removed the no-issue-activity No issue activity label Mar 24, 2024
@Manik2708
Copy link
Contributor

image

1. I can remove any org even if I do not belong to that org.

2. I can disable any plugin even if I do not belong to that org.
  1. You must be logged in with SUPERADMIN. I can see in the code, only superadmin can remove the organization. If it's not superadmin then an error is thrown.
  2. I can't find mutation to disable plugin. Can you help me with finding it?

@palisadoes
Copy link
Contributor

@SiddheshKukade Please assist with the plugin question

@Manik2708
Copy link
Contributor

After searching a bit, I found a mutation named updatePluginStatus. Are you talking about this? @krishna619

@krishna619
Copy link
Contributor Author

krishna619 commented Mar 26, 2024

there is a mutation called blockPluginCreationBySuperAdmin, and I feel after the userType merge, it has been handled.

Manik2708

@Manik2708
Copy link
Contributor

there is a mutation called blockPluginCreationBySuperAdmin, and I feel after the userType merge, it has been handled.

Manik2708

As the name suggests, it can only be done by SUPERADMIN, so it doesn't need to be the member of organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature request security Security fix
Projects
None yet
Development

No branches or pull requests

6 participants