Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: src/libraries/errors/ImageSizeLimitExceeded.ts` #1819

Closed
palisadoes opened this issue Feb 8, 2024 · 9 comments
Closed

Test: src/libraries/errors/ImageSizeLimitExceeded.ts` #1819

palisadoes opened this issue Feb 8, 2024 · 9 comments
Assignees
Labels
feature request parent Parent issue test Testing application

Comments

@palisadoes
Copy link
Contributor

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

  1. Tests need to be written for file src/libraries/errors/ImageSizeLimitExceeded.ts
  2. We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  3. When complete, all all methods, classes and/or functions in the refactored file will need to be tested.
  4. These tests must be placed in a single file with the same path as the tested file, but under the tests/ with a .spec.ts suffix.
  5. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found by visting this page. Login using your GitHub credentials.
  • Create your own codecov.io to help with testing.
  • The PR you create will show a report for the code coverage for the file you have added. You can also use that as a guide.

Other

Please coordinate issue assignment and PR reviews with the contributors listed in this issue:

@github-actions github-actions bot added parent Parent issue test Testing application unapproved Unapproved for Pull Request labels Feb 8, 2024
@lokeshwar777
Copy link
Contributor

I would like to work on this issue

@plasma018 plasma018 removed the unapproved Unapproved for Pull Request label Feb 10, 2024
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Feb 21, 2024
@Cioppolo14
Copy link
Contributor

@lokeshwar777 Are you working on this?

@github-actions github-actions bot removed the no-issue-activity No issue activity label Feb 22, 2024
@samiali12
Copy link
Contributor

@Cioppolo14 I would like to work on this issue.

@Cioppolo14
Copy link
Contributor

Unassigning due to no activity or open PR.

@samiali12
Copy link
Contributor

@Cioppolo14 I have opened a pull request to address issue #1819. Please review it.

Copy link

github-actions bot commented Mar 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 18, 2024
@samiali12
Copy link
Contributor

Already open PR on this issue

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request parent Parent issue test Testing application
Projects
None yet
Development

No branches or pull requests

5 participants