-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Recurring Events #1734
feat: Create Recurring Events #1734
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1734 +/- ##
===========================================
+ Coverage 97.51% 98.20% +0.69%
===========================================
Files 176 182 +6
Lines 4298 4511 +213
Branches 1237 1295 +58
===========================================
+ Hits 4191 4430 +239
+ Misses 103 77 -26
Partials 4 4 ☔ View full report in Codecov by Sentry. |
This is an update on the PR merging freeze:
We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise. Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST). If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new |
77974c2
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
It adds functionality for creating recurring events:
Issue Number:
Fixes #1643
Did you add tests for your changes?
Yes
Demo:
recurrence-options.mp4
daily-and-weekly.mp4
custom-recurrence.mp4
Additional Context
This is the first PR in the series for this issue. After this, updation and deletion of recurring events would be implemented.
talawa-api issue: PalisadoesFoundation/talawa-api#1583
talawa-api create recurring events functionality: PalisadoesFoundation/talawa-api#1807
Next PR: #1817