Check for NotMaker on claimNFTs

PaintSwap · Aug 5, 2024 · f67d77c · f67d77c
1 parent 5235367
commit f67d77c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/contracts/SamWitchOrderBook.sol b/contracts/SamWitchOrderBook.sol
@@ -380,6 +380,11 @@ contract SamWitchOrderBook is ISamWitchOrderBook, ERC1155Holder, UUPSUpgradeable
       if (amount == 0) {
         revert NothingToClaim();
       }
+
+      if (tokenClaimable[orderId].maker != _msgSender()) {
+        revert NotMaker();
+      }
+
       nftAmountsFromUs[i] = amount;
       amountClaimableForTokenId[tokenId][orderId] = 0;
     }

diff --git a/test/SamWitchOrderBook.ts b/test/SamWitchOrderBook.ts
@@ -2733,6 +2733,13 @@ describe("SamWitchOrderBook", function () {
         expect((await orderBook.nftsClaimable([orderId], [tokenId]))[0]).to.eq(10);
         expect((await orderBook.nftsClaimable([orderId + 1], [tokenId]))[0]).to.eq(0);
 
+        // try to claim as a different user (not maker)
+        await expect(orderBook.connect(alice).claimNFTs([orderId], [tokenId])).to.be.revertedWithCustomError(
+          orderBook,
+          "NotMaker",
+        );
+
+        // claim as the maker
         await expect(orderBook.claimNFTs([orderId], [tokenId]))
           .to.emit(orderBook, "ClaimedNFTs")
           .withArgs(owner.address, [orderId], [tokenId], [10]);